Skip to content

OCPBUGS-61858: Use pointer type for HTTPKeepAliveTimeout in IngressController API #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
+6 −2
Merged

OCPBUGS-61858: Use pointer type for HTTPKeepAliveTimeout in IngressController API #2591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion operator/v1/types_ingress.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1912,7 +1912,7 @@ type IngressControllerTuningOptions struct {
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=16
// +optional
HTTPKeepAliveTimeout metav1.Duration `json:"httpKeepAliveTimeout,omitempty"`
HTTPKeepAliveTimeout *metav1.Duration `json:"httpKeepAliveTimeout,omitempty"`
Copy link
Contributor

@everettraven everettraven Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to avoid pointers where possible.

If the zero value is not a valid value, there isn't really any need for a pointer. It looks like metav1.Duration is a struct and not a type alias.

Does adding omitzero resolve this issue?

Suggested change
HTTPKeepAliveTimeout *metav1.Duration `json:"httpKeepAliveTimeout,omitempty"`
HTTPKeepAliveTimeout metav1.Duration `json:"httpKeepAliveTimeout,omitempty,omitzero"`

Copy link
Contributor

@everettraven everettraven Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alebedev87 reminded me that this needs to be backported to 4.16 which will not support the omitzero tag.

Pointer is correct here.


// tlsInspectDelay defines how long the router can hold data to find a
// matching route.
Expand Down
6 changes: 5 additions & 1 deletion operator/v1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.