Skip to content

dnm test pipelines 3 #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmguzik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

dnm test pipelines 3 #2687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile.ocp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder
FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder
Copy link

@coderabbitai coderabbitai bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Extraneous whitespace in FROM instruction.

The FROM instruction contains extra spaces (FROM registry... instead of FROM registry...). While Docker tolerates this, it deviates from standard formatting conventions and may indicate an unintended edit.

🧹 Proposed fix 
-FROM   registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder
+FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder
FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22 AS builder
🤖 Prompt for AI Agents 
In `@Dockerfile.ocp` at line 1, The FROM instruction in the Dockerfile has
extraneous spaces ("FROM   registry...") causing non-standard formatting; update
the Dockerfile's FROM instruction by removing the extra spaces so it reads "FROM
registry..." (locate and edit the FROM line in the Dockerfile.ocp/ Dockerfile
and adjust the FROM instruction accordingly) to follow standard Dockerfile
formatting.

WORKDIR /go/src/github.com/openshift/api
COPY . .
ENV GO_PACKAGE github.com/openshift/api
Expand Down
2 changes: 1 addition & 1 deletion console/v1/tests/consoleplugins.console.openshift.io/AAA_ungated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ crdName: consoleplugins.console.openshift.io
version: v1
tests:
onCreate:
- name: Should be able to create a minimal ConsolePlugin
- name: Should be able to cr eate a minimal ConsolePlugin
Copy link

@coderabbitai coderabbitai bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: double space in test name.

The test name contains an extra space in "create" ("cr eate" → should be "create"). This will appear in test reports and affects searchability.

✏️ Proposed fix 
-    - name: Should be able to cr  eate a minimal ConsolePlugin
+    - name: Should be able to create a minimal ConsolePlugin
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Should be able to cr eate a minimal ConsolePlugin
- name: Should be able to create a minimal ConsolePlugin
🤖 Prompt for AI Agents 
In `@console/v1/tests/consoleplugins.console.openshift.io/AAA_ungated.yaml` at
line 7, The test name string "Should be able to cr  eate a minimal
ConsolePlugin" contains a double space inside "create"; update the YAML value
for the test's name (the string value currently set to that exact phrase) to
"Should be able to create a minimal ConsolePlugin" by removing the extra space
so test reports and searches show the correct name.

initial: |
apiVersion: console.openshift.io/v1
kind: ConsolePlugin
Expand Down
2 changes: 1 addition & 1 deletion features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
func FeatureSets(clusterProfile ClusterProfileName, featureSet configv1.FeatureSet) (*FeatureGateEnabledDisabled, error) {
byFeatureSet, ok := allFeatureGates[clusterProfile]
if !ok {
return nil, fmt.Errorf("no information found for ClusterProfile=%q", clusterProfile)
return nil, fmt.Errorf("no information found for ClusterProfile=%q", clusterProfile)
Copy link

@coderabbitai coderabbitai bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Typo: double space in error message.

The error message contains an extra space ("no information found for" → should be "no information found for"). This affects the quality of error output.

✏️ Proposed fix 
-		return nil, fmt.Errorf("no information found  for ClusterProfile=%q", clusterProfile)
+		return nil, fmt.Errorf("no information found for ClusterProfile=%q", clusterProfile)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
return nil, fmt.Errorf("no information found for ClusterProfile=%q", clusterProfile)
return nil, fmt.Errorf("no information found for ClusterProfile=%q", clusterProfile)
🤖 Prompt for AI Agents 
In `@features/features.go` at line 12, Fix the typo in the error string used in
the fmt.Errorf call that returns when no data exists: locate the fmt.Errorf(...)
invocation that formats "no information found  for ClusterProfile=%q" (which
uses the clusterProfile variable) and remove the extra space so it reads "no
information found for ClusterProfile=%q".

}
featureGates, ok := byFeatureSet[featureSet]
if !ok {
Expand Down
1 change: 1 addition & 0 deletions payload-manifests/featuregates/featureGate-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
"name": "cluster"
},
"spec": {},

"status": {
"featureGates": [
{
Expand Down