Skip to content

Bug 1749581: operator/ingress: Fix scale kubebuilder marker #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2019
Merged

Bug 1749581: operator/ingress: Fix scale kubebuilder marker #425

merged 1 commit into from
Sep 11, 2019

Conversation

@Miciah
Copy link
Contributor

@Miciah Miciah commented Sep 5, 2019

  • operator/v1/types_ingress.go: Fix the kubebuilder marker for the IngressController resource's scale subresource's labelSelectorPath field.

@Miciah
operator/ingress: Fix scale kubebuilder marker
e6c3eea 
* operator/v1/types_ingress.go: Fix the kubebuilder marker for the
IngressController resource's scale subresource's labelSelectorPath field.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2019
@Miciah Miciah mentioned this pull request Sep 5, 2019
Merged
@Miciah
Copy link
Contributor Author

Miciah commented Sep 5, 2019

/retitle Bug 1749581: operator/ingress: Fix scale kubebuilder marker

@openshift-ci-robot openshift-ci-robot changed the title operator/ingress: Fix scale kubebuilder marker Bug 1749581: operator/ingress: Fix scale kubebuilder marker Sep 5, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 5, 2019

@Miciah: This pull request references Bugzilla bug 1749581, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1749581: operator/ingress: Fix scale kubebuilder marker

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 5, 2019
@ironcladlou
Copy link
Contributor

ironcladlou commented Sep 5, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 5, 2019
@ironcladlou
Copy link
Contributor

ironcladlou commented Sep 6, 2019

@deads2k @sttts @damemi PTAL

soltysh
soltysh approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit 9f80b78 into openshift:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ironcladlou ironcladlou

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Miciah @openshift-ci-robot @ironcladlou @soltysh @openshift-merge-robot