add KubeStorageVersionMigrator crd.yaml #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
added a commit
to wking/openshift-api
that referenced
this pull request
Sep 27, 2023
The outgoing run level 40 is from file creation in 8802379 (add KubeStorageVersionMigrator crd.yaml, 2019-10-29, openshift#503), but that commit does not give a motivation for selecting level 40. Moving to level 50 will align this manifest with the other migrator manifests: $ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.14.0-rc.2-x86_64 $ ls manifests/*kube-storage-version-migrator* manifests/0000_40_kube-storage-version-migrator-operator_00_config.crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_01_storage_migration_crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_01_storage_state_crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_02_namespace.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_03_configmap.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_04_serviceaccount.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_05_roles.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_06_operatorconfig.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_07_deployment-ibm-cloud-managed.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_07_deployment.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_08_service.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_09_clusteroperator.yaml catching up with openshift/cluster-kube-storage-version-migrator-operator@626f35773607 (manifests: remove special runlevel, 2021-10-21, openshift/cluster-kube-storage-version-migrator-operator#70). By consolidating, we remove the only remaining level-40 manifest, saving some time by shifting that manifest to the highly-parallel default level 50. The new filename will require a small tweak to the Dockerfile's [1]: COPY vendor/github.com/openshift/api/operator/v1/*_kube-storage-version-migrator-operator_*.yaml* /manifests but that can happen when we vendor-bump the operator to pull in this change. [1]: https://github.com/openshift/cluster-kube-storage-version-migrator-operator/blob/332cb1cd0f9a00c03e3f9d400ae8483abd03036c/images/ci/Dockerfile#L10C38-L10C98
wking
added a commit
to wking/openshift-api
that referenced
this pull request
Sep 28, 2023
The outgoing run level 40 is from file creation in 8802379 (add KubeStorageVersionMigrator crd.yaml, 2019-10-29, openshift#503), but that commit does not give a motivation for selecting level 40. Moving to level 50 will align this manifest with the other migrator manifests: $ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.14.0-rc.2-x86_64 $ ls manifests/*kube-storage-version-migrator* manifests/0000_40_kube-storage-version-migrator-operator_00_config.crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_01_storage_migration_crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_01_storage_state_crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_02_namespace.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_03_configmap.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_04_serviceaccount.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_05_roles.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_06_operatorconfig.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_07_deployment-ibm-cloud-managed.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_07_deployment.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_08_service.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_09_clusteroperator.yaml catching up with openshift/cluster-kube-storage-version-migrator-operator@626f35773607 (manifests: remove special runlevel, 2021-10-21, openshift/cluster-kube-storage-version-migrator-operator#70). By consolidating, we remove the only remaining level-40 manifest, saving some time by shifting that manifest to the highly-parallel default level 50. The new filename will require a small tweak to the Dockerfile's [1]: COPY vendor/github.com/openshift/api/operator/v1/*_kube-storage-version-migrator-operator_*.yaml* /manifests but that can happen when we vendor-bump the operator to pull in this change. [1]: https://github.com/openshift/cluster-kube-storage-version-migrator-operator/blob/332cb1cd0f9a00c03e3f9d400ae8483abd03036c/images/ci/Dockerfile#L10C38-L10C98
wking
added a commit
to wking/openshift-api
that referenced
this pull request
Oct 2, 2023
The outgoing run level 40 is from file creation in 8802379 (add KubeStorageVersionMigrator crd.yaml, 2019-10-29, openshift#503), but that commit does not give a motivation for selecting level 40. Moving to level 50 will align this manifest with the other migrator manifests: $ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.14.0-rc.2-x86_64 $ ls manifests/*kube-storage-version-migrator* manifests/0000_40_kube-storage-version-migrator-operator_00_config.crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_01_storage_migration_crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_01_storage_state_crd.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_02_namespace.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_03_configmap.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_04_serviceaccount.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_05_roles.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_06_operatorconfig.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_07_deployment-ibm-cloud-managed.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_07_deployment.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_08_service.yaml manifests/0000_50_cluster-kube-storage-version-migrator-operator_09_clusteroperator.yaml catching up with openshift/cluster-kube-storage-version-migrator-operator@626f35773607 (manifests: remove special runlevel, 2021-10-21, openshift/cluster-kube-storage-version-migrator-operator#70). By consolidating, we remove the only remaining level-40 manifest, saving some time by shifting that manifest to the highly-parallel default level 50. The new filename will require a small tweak to the Dockerfile's [1]: COPY vendor/github.com/openshift/api/operator/v1/*_kube-storage-version-migrator-operator_*.yaml* /manifests but that can happen when we vendor-bump the operator to pull in this change. [1]: https://github.com/openshift/cluster-kube-storage-version-migrator-operator/blob/332cb1cd0f9a00c03e3f9d400ae8483abd03036c/images/ci/Dockerfile#L10C38-L10C98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CRD resource definition for KubeStorageVersionMigrator types.