Skip to content

Conversation

@alexanderConstantinescu
Copy link
Contributor

This fixes a minor issue with the CRD for cloud private IP configs. The CRD's spec.names.plural is currently incorrect and needs updating as the controller fails to find the resource as it currently stands.

/assign @danwinship @sttts

Signed-off-by: Alexander Constantinescu <aconstan@redhat.com>
@openshift-ci-robot
Copy link

@alexanderConstantinescu: An error was encountered querying GitHub for users with public email (anusaxen@redhat.com) for bug 1952795 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1952795: fix plural name for CloudPrivateIPConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Contributor

sttts commented Apr 23, 2021

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2021
@alexanderConstantinescu
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderConstantinescu, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2021
@openshift-ci-robot
Copy link

@alexanderConstantinescu: An error was encountered querying GitHub for users with public email (anusaxen@redhat.com) for bug 1952795 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexanderConstantinescu
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@alexanderConstantinescu: This pull request references Bugzilla bug 1952795, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 156ca80 into openshift:master Apr 23, 2021
@openshift-ci-robot
Copy link

@alexanderConstantinescu: All pull requests linked via external trackers have merged:

Bugzilla bug 1952795 has been moved to the MODIFIED state.

In response to this:

Bug 1952795: fix plural name for CloudPrivateIPConfig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants