NE-2074: UPSTREAM: <carry>: Enable Konflux dependencies updates, disable gomod bumps #59
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@grzpiotrowski: This pull request references NE-2074 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@grzpiotrowski: This pull request references NE-2074 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| "branchTopic": "{{{baseBranch}}}", | ||
| "commitMessageTopic": "{{{groupName}}}" | ||
| }, | ||
| "commitMessageTopic": "Konflux references", |
There was a problem hiding this comment.
Can we have a carry patch prefix?
| "commitMessageTopic": "Konflux references", | |
| "commitMessageTopic": "UPSTREAM <carry>: Konflux references", |
There was a problem hiding this comment.
I was under the impression that the commit prefix we have set in the broader scope would handle this, but I think you're right and I added this now.
There was a problem hiding this comment.
I was under the impression that the commit prefix we have set in the broader scope would handle this
I'm not sure either. Can a dry-run help us here or not?
There was a problem hiding this comment.
Right, I just did a dry-run with commitMessageTopic": "Konflux references", and it correctly adds the prefix from the broader config that we have. I reverted this line back to this version.
Fragment from the dry-run:
"branchesInformation": [
{
"branchName": "konflux/references/main",
"prNo": null,
"prTitle": "UPSTREAM: <carry>: Update Konflux references",
"result": "not-scheduled",
"upgrades": [ ...Interestingly when I tested with "commitMessageTopic": "UPSTREAM <carry>: Konflux references", it would not duplicate that prefix.
The dry run only shows the PR titles but looks like they are the same as commit messages.
| "postUpgradeTasks": { | ||
| "commands": [ | ||
| "pipeline-migration-tool migrate -f \"$RENOVATE_POST_UPGRADE_COMMAND_DATA_FILE\"" | ||
| ], | ||
| "executionMode": "branch", | ||
| "dataFileTemplate": "[{{#each upgrades}}{\"depName\": \"{{{depName}}}\", \"currentValue\": \"{{{currentValue}}}\", \"currentDigest\": \"{{{currentDigest}}}\", \"newValue\": \"{{{newValue}}}\", \"newDigest\": \"{{{newDigest}}}\", \"packageFile\": \"{{{packageFile}}}\", \"parentDir\": \"{{{parentDir}}}\", \"depTypes\": [{{#each depTypes}}\"{{{this}}}\"{{#unless @last}},{{\/unless}}{{\/each}}]}{{#unless @last}},{{\/unless}}{{\/each}}]" | ||
| } |
There was a problem hiding this comment.
What does it do exactly post upgrade?
There was a problem hiding this comment.
It is part of the default MintMaker configuration. That is the one which is in place when there is no renovate.json file existing in the repo.
Also we could technically use the extends field in our renovate config and point to that file, then disable whatever configuration we don't want from there. But since we have set very specific requirements I reckon we can stay at the configuration in the current form where we add what is needed instead of disabling things from the extended default config.
To answer the question though after some research: this executes the konflux-ci/pipeline-migration-tool which handles any configuration updates needed to the pipelines after the version bump. Like when some parameters change from version to version etc.
links:
grzpiotrowski
force-pushed
the
renovate-dependency-management
branch
from
29909e3 to
8a400ed
Compare
…ble gomod bumps - Add weekly Konflux dependencies updates grouped into a single PR. - Add weekly schedule for Containerfile images updates. - Disable all gomod bump PRs.
grzpiotrowski
force-pushed
the
renovate-dependency-management
branch
from
8a400ed to
5231ce4
Compare
|
@grzpiotrowski: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
3 participants
Konflux dependencies updates configuration was taken from konflux-ci/mintmaker/config/renovate
/renovate.json
One difference is that updates to
quay.io/konflux-ci/konflux-vanguardwere also added to be grouped into a single PR. The source config only groups together the updates to:quay.io/konflux-ci/tekton-catalogandquay.io/redhat-appstudio-tekton-catalog.