Skip to content

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented May 28, 2024

Normally, cli-manager-operator does not need to install git binary as it only provisions and manages cli-manager operand. However, in order to sync with cli-manager Dockerfile (openshift/cli-manager#14), this PR performs the same changes.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
@openshift-ci openshift-ci bot requested a review from ingvagabund May 28, 2024 11:27
@ardaguclu ardaguclu changed the title WIP: Copy git binary from builder instead of installing WIP: WRKLDS-1295: Copy git binary from builder instead of installing May 28, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 28, 2024

@ardaguclu: This pull request references WRKLDS-1295 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 28, 2024

@ardaguclu: This pull request references WRKLDS-1295 which is a valid jira issue.

In response to this:

The image registry.redhat.io/rhel9-2-els/rhel:9.2-1222 we are now using to integrate with Konflux disables the RPM repositories. Moreover, Konflux does not explicitly enable repositories currently. We can wait the enablement of these repositories to install git. However, in case we can unblock ourselves by copying this binary from builder image, this PR tries to achieve this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 28, 2024

@ardaguclu: This pull request references WRKLDS-1295 which is a valid jira issue.

In response to this:

Normally, cli-manager-operator does not need to install git binary as it only provisions and manages cli-manager operand. However, in order to sync with cli-manager Dockerfile (openshift/cli-manager#14), this PR performs the same changes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu ardaguclu changed the title WIP: WRKLDS-1295: Copy git binary from builder instead of installing WRKLDS-1295: Copy git binary from builder instead of installing May 28, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 28, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 28, 2024

@ardaguclu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@openshift-ci
Copy link

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ardaguclu,ingvagabund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f26267a into openshift:main May 28, 2024
@ardaguclu ardaguclu deleted the copy-git-binary branch May 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants