-
Notifications
You must be signed in to change notification settings - Fork 47
New 'aws-actuator bootstrap` command to bootstrap the kubernetes cluster from scratch #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 'aws-actuator bootstrap` command to bootstrap the kubernetes cluster from scratch #26
Conversation
cmd/aws-actuator/main.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot we just execute above commands instead of creating bash script user-data.sh just so we can later execute it? If logs are important, we can just use >> to append to log file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@frobware could tell more how useful that is :)
In case something goes wrong you might want to re-run the shell script without creating a new instance. Anyway, it's still an example and only for demonstration. Not meant to be run in production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I found it useful to rerun.
But I think we also have to be careful -- there's limited value for absolute perfection here as they're really examples and will disappear over time.
Makefile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not aws-actuator? Would naturally yield make aws-actuator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. Updated.
|
/test all |
|
/test e2e |
|
I tried running it: It would be tremendously helpful to print the public IP too. |
Later mate. We need to pull the aws instance status. So I would rather wait until we have that functionality in the code rather than do the mambo jambo in the code. Unless you have a simple way in mind how to do it? |
|
/retest |
|
/test e2e |
|
@ingvagabund: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🐛 Fix tekton tasks
Just run
./bin/aws-actuator bootstrap --manifests examples/and get: