Skip to content

Conversation

@ingvagabund
Copy link
Member

Just run ./bin/aws-actuator bootstrap --manifests examples/ and get:

$ sudo kubectl get nodes
NAME                            STATUS    ROLES     AGE       VERSION
ip-172-31-33-59.ec2.internal    Ready     master    1m        v1.11.2
ip-172-31-35-115.ec2.internal   Ready     <none>    52s       v1.11.2

@ingvagabund
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot we just execute above commands instead of creating bash script user-data.sh just so we can later execute it? If logs are important, we can just use >> to append to log file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frobware could tell more how useful that is :)

In case something goes wrong you might want to re-run the shell script without creating a new instance. Anyway, it's still an example and only for demonstration. Not meant to be run in production.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I found it useful to rerun.

But I think we also have to be careful -- there's limited value for absolute perfection here as they're really examples and will disappear over time.

Makefile Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not aws-actuator? Would naturally yield make aws-actuator.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Updated.

@ingvagabund
Copy link
Member Author

/test all

@ingvagabund
Copy link
Member Author

/test e2e

@frobware
Copy link

I tried running it:

INFO[0001] Master machine created with ipv4: 172.31.38.217, InstanceId: i-087bc8693bc299a35 

It would be tremendously helpful to print the public IP too.

@ingvagabund
Copy link
Member Author

It would be tremendously helpful to print the public IP too.

Later mate. We need to pull the aws instance status. So I would rather wait until we have that functionality in the code rather than do the mambo jambo in the code. Unless you have a simple way in mind how to do it?

@paulfantom
Copy link

/retest

@paulfantom
Copy link

/test e2e

@openshift-ci-robot
Copy link

@ingvagabund: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 82b92cd link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@paulfantom
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ingvagabund,paulfantom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2018
@ingvagabund ingvagabund changed the title WIP: New 'aws-actuator bootstrap` command to bootstrap the kubernetes cluster from scratch New 'aws-actuator bootstrap` command to bootstrap the kubernetes cluster from scratch Aug 24, 2018
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 24, 2018
@ingvagabund ingvagabund merged commit 1dc8e5c into openshift:master Aug 24, 2018
@ingvagabund ingvagabund deleted the bootstrap-kubernetes-cluster-via-kubeadm branch August 24, 2018 18:57
vikaschoudhary16 pushed a commit to vikaschoudhary16/cluster-api-provider-aws that referenced this pull request Jan 16, 2019
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/cluster-api-provider-aws that referenced this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants