Skip to content

LOG-1746: Switch to the kubebuilder v3. Upgrade operator-sdk to the v1.11.0 #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

LOG-1746: Switch to the kubebuilder v3. Upgrade operator-sdk to the v1.11.0 #1200

merged 1 commit into from
Oct 11, 2021

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Oct 4, 2021 •
edited
Loading

Signed-off-by: Vitalii Parfonov vparfono@redhat.com

Description

This PR addresses several dependency updates:

  • operator-sdk from v1.2.0 to v1.11.0
  • controller-runtime from v0.6.3 to v0.9.2
  • k8s deps bump from v0.18.8 to v0.21.2
  • kubebuilder layout from v2 to v3 to enable continuous maintenance of the operator.

/cc @periklis
/assign @jcantrill

/cherry-pick

Links

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 4, 2021
@vparfonov
Copy link
Contributor Author

/test all

@openshift-ci openshift-ci bot added the midstream/Dockerfile A Dockerfile.in sync is needed with midstream label Oct 4, 2021
@vparfonov
Copy link
Contributor Author

/test unit

@vparfonov
Copy link
Contributor Author

/test unit

1 similar comment
@vparfonov
Copy link
Contributor Author

/test unit

@vparfonov
Copy link
Contributor Author

/test unit

3 similar comments
@vparfonov
Copy link
Contributor Author

/test unit

@vparfonov
Copy link
Contributor Author

/test unit

@vparfonov
Copy link
Contributor Author

/test unit

@vparfonov
Copy link
Contributor Author

/test functional

@vparfonov
Copy link
Contributor Author

/test unit

1 similar comment
@vparfonov
Copy link
Contributor Author

/test unit

@vparfonov
Copy link
Contributor Author

/test all

1 similar comment
@vparfonov
Copy link
Contributor Author

/test all

@vparfonov
Copy link
Contributor Author

/test e2e-gcp

1 similar comment
@vparfonov
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 8, 2021
@vparfonov
Copy link
Contributor Author

/test e2e-gcp

3 similar comments
@vparfonov
Copy link
Contributor Author

/test e2e-gcp

@vparfonov
Copy link
Contributor Author

/test e2e-gcp

@vparfonov
Copy link
Contributor Author

/test e2e-gcp

@vparfonov
Switch to the kubebuilder v3. Upgrade operator-sdk to the v1.11.0
0c3b6f0 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@vparfonov vparfonov marked this pull request as ready for review October 11, 2021 08:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2021
@vparfonov vparfonov changed the title Switch to the kubebuilder v3. Upgrade operator-sdk to the v1.11.0 LOG-1746: Switch to the kubebuilder v3. Upgrade operator-sdk to the v1.11.0 Oct 11, 2021
jcantrill
jcantrill reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@openshift-merge-robot openshift-merge-robot merged commit 068697e into openshift:master Oct 11, 2021
@vparfonov vparfonov deleted the log1746 branch October 11, 2021 13:58
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#1200 from vparfonov/log1746
7c5b62b 
LOG-1746: Switch to the kubebuilder v3. Upgrade operator-sdk to the v1.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill left review comments

@ajaygupta978 ajaygupta978 Awaiting requested review from ajaygupta978

@syedriko syedriko Awaiting requested review from syedriko

Assignees

@jcantrill jcantrill

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. midstream/Dockerfile A Dockerfile.in sync is needed with midstream

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vparfonov @jcantrill @openshift-merge-robot