Skip to content

Conversation

ajaygupta978
Copy link
Contributor

@ajaygupta978 ajaygupta978 commented Jan 27, 2022

Description

When different log types are sent to different stores vector configuration is incorrect. Please see attached Jira ticket to see an example.

/cc @vimalk78

@openshift-ci openshift-ci bot requested a review from vimalk78 January 27, 2022 11:00
@ajaygupta978 ajaygupta978 force-pushed the LOG_2166_Vector_Multiple_Logstore branch from de914e2 to 1845876 Compare January 28, 2022 04:30
@ajaygupta978 ajaygupta978 force-pushed the LOG_2166_Vector_Multiple_Logstore branch from 1845876 to 5742590 Compare January 28, 2022 14:50
@ajaygupta978
Copy link
Contributor Author

/test e2e

1 similar comment
@ajaygupta978
Copy link
Contributor Author

/test e2e

Copy link
Contributor

@vimalk78 vimalk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ajaygupta978, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@ajaygupta978
Copy link
Contributor Author

/test functional

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 31, 2022

@ajaygupta978: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 0ee36f0 into openshift:master Jan 31, 2022
pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
…ultiple_Logstore

LOG-2166: Fail when different type logs to different log stores
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants