Skip to content

WIP LOG-2014:Support user defined application inputs #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

WIP LOG-2014:Support user defined application inputs #1359

wants to merge 14 commits into from

Conversation

ajaygupta978
Copy link
Contributor

@ajaygupta978 ajaygupta978 commented Mar 1, 2022 •
edited
Loading

Adding E2E test case which verifies logs are filtered based on name space.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2022
@ajaygupta978 ajaygupta978 marked this pull request as draft March 2, 2022 10:52
@ajaygupta978 ajaygupta978 marked this pull request as ready for review March 2, 2022 10:52
@openshift-ci openshift-ci bot requested review from alanconway and vparfonov March 2, 2022 10:55
@vimalk78
Copy link
Contributor

vimalk78 commented Mar 3, 2022

i will suggest to change in namespace_filtering_test.go and enable the same test in it for vector.

The test has nothing specific about fluentd, not sure why it got added to fluentd folder. you can move the file to proper place if you think.

@ajaygupta978
Copy link
Contributor Author

/test e2e

1 similar comment
@ajaygupta978
Copy link
Contributor Author

/test e2e

@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch from f7ca29a to df8c13a Compare March 10, 2022 06:40
@ajaygupta978
Copy link
Contributor Author

/test e2e

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2022
@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch from 38bd4ae to 88c150d Compare March 12, 2022 04:44
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2022
@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch 2 times, most recently from 46b1ef9 to 012d12d Compare March 15, 2022 07:06
@ajaygupta978
Copy link
Contributor Author

/test functional

@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch 2 times, most recently from cc14173 to a31c8fa Compare March 15, 2022 10:07
vimalk78
vimalk78 reviewed Mar 15, 2022
View reviewed changes
@alanconway
Copy link
Contributor

DescribeTable/Entry is the Ginkgo construct for writing repetative "table tests", there are examples in the tests.

jcantrill
jcantrill reviewed Mar 16, 2022
View reviewed changes
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 17, 2022
@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch from a31c8fa to 78031ea Compare March 21, 2022 11:35
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2022
@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch from 78031ea to 057c3fa Compare March 21, 2022 12:30
@ajaygupta978
Copy link
Contributor Author

/test e2e

2 similar comments
@ajaygupta978
Copy link
Contributor Author

/test e2e

@ajaygupta978
Copy link
Contributor Author

/test e2e

@jcantrill
Copy link
Contributor

@jcantrill #1359 (comment) Do you mean why we wrote new test case ? In the old package we had only fluentd test case which was using fluent forward as end point. Since vector doesn't support it so we have to elastic search as common end point for fluentd and vector. This required new code to be written in elasticsearch.go.

this is mostly the same testcase which means you could "git mv" it to a new package and edit it accordingly. This preserves history which can be important during investigation

@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch from 0c5fdb4 to 8730ffa Compare April 7, 2022 20:19
@ajaygupta978 ajaygupta978 force-pushed the LOG-2014-UserDefined branch from 8730ffa to 2b1c02d Compare April 8, 2022 07:07
@ajaygupta978
Copy link
Contributor Author

/test e2e

@ajaygupta978
Copy link
Contributor Author

/test functional

@ajaygupta978
Copy link
Contributor Author

/test e2e

1 similar comment
@ajaygupta978
Copy link
Contributor Author

/test e2e

@ajaygupta978
Copy link
Contributor Author

/test e2e

@ajaygupta978
Copy link
Contributor Author

/test functional

1 similar comment
@ajaygupta978
Copy link
Contributor Author

/test functional

@ajaygupta978
Copy link
Contributor Author

/test functional

@ajaygupta978
Copy link
Contributor Author

/retest

@ajaygupta978
Copy link
Contributor Author

/test functional

1 similar comment
@ajaygupta978
Copy link
Contributor Author

/test functional

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 14, 2022

@ajaygupta978: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/lint ce61494 link true /test lint
ci/prow/e2e ce61494 link true /test e2e
ci/prow/functional ce61494 link true /test functional

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill jcantrill closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill requested changes

@pmoogi-redhat pmoogi-redhat Awaiting requested review from pmoogi-redhat

@vparfonov vparfonov Awaiting requested review from vparfonov

+2 more reviewers

@vimalk78 vimalk78 vimalk78 left review comments

@alanconway alanconway alanconway approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ajaygupta978 @vimalk78 @alanconway @jcantrill