Skip to content

Conversation

cahartma
Copy link
Contributor

@cahartma cahartma commented Jun 15, 2022

Description

Verify users can forward application logs by specifying a namespace.
Verify users can forward application logs by specifying pod labels.
Verify comparable functionality with fluentd.

Note:
All vector forwarding has been tested using cloudwatch. We do not currently have a functional test for forwarding by specifying namespace since vector lacks the meta namespace.uid. An upcoming release of vector will contain the additional data needed to write the test.

/assign @vimalk78 @jcantrill @syedriko

Links

@cahartma cahartma force-pushed the LOG-2014-vector-support-user-defined-app-inputs branch from 86faa13 to 530e89a Compare June 15, 2022 16:34
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2022
@cahartma cahartma force-pushed the LOG-2014-vector-support-user-defined-app-inputs branch from 530e89a to b208531 Compare June 15, 2022 16:41
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2022
@cahartma
Copy link
Contributor Author

/retest

@vimalk78
Copy link
Contributor

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 6c7cf78 and 8 for PR HEAD b208531 in total

@cahartma
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit f7c44df into openshift:master Jun 16, 2022
@cahartma cahartma deleted the LOG-2014-vector-support-user-defined-app-inputs branch June 21, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants