Skip to content

Conversation

cahartma
Copy link
Contributor

@cahartma cahartma commented Jul 23, 2024

Description

The validation error can also be verified by trying to applying the CRD to the cluster. I was not able to reproduce the "CRD is not present" errors, but I am assuming the first (validation) error is causing the requirementStatus to fail as well.

Also adding a shortname back into the CRD. In case of upgrade scenario, user can now use obsclf (until we remove the old CRD)

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2024

@cahartma: This pull request references LOG-5862 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

The validation error can also be verified by trying to applying the CRD to the cluster. I was not able to reproduce the "CRD is not present" errors, but I am assuming the first (validation) error is causing the requirementStatus to fail as well.

Also adding a shortname back into the CRD. In case of upgrade scenario, user can now use obsclf (until we remove the old CRD)

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2024
@openshift-ci openshift-ci bot requested review from Clee2691 and vparfonov July 23, 2024 18:49
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 23, 2024

@cahartma: This pull request references LOG-5862 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

The validation error can also be verified by trying to applying the CRD to the cluster. I was not able to reproduce the "CRD is not present" errors, but I am assuming the first (validation) error is causing the requirementStatus to fail as well.

Also adding a shortname back into the CRD. In case of upgrade scenario, user can now use obsclf (until we remove the old CRD)

/cc @Clee2691 @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cahartma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@cahartma cahartma force-pushed the LOG-5862-clo-install-errors branch from 7cafdac to eeb3b43 Compare July 23, 2024 19:54
@jcantrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1db0661 and 2 for PR HEAD eeb3b43 in total

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

@cahartma: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c909071 into openshift:master Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants