Skip to content

Conversation

Clee2691
Copy link
Contributor

@Clee2691 Clee2691 commented Oct 29, 2024

Description

This PR normalizes log severity levels for the GCL sink based on GCL's standard referenced below.
The severity level of audit logs is INFO.

Ref: https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry#logseverity

/cc @cahartma @vparfonov
/assign @jcantrill

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2024

@Clee2691: This pull request references LOG-6296 which is a valid jira issue.

In response to this:

Description

This PR normalizes log severity levels based on GCL's standard.
The severity level of audit logs is INFO.

Ref: https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry#logseverity

/cc @cahartma @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cahartma and vparfonov October 29, 2024 22:00
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2024

@Clee2691: This pull request references LOG-6296 which is a valid jira issue.

In response to this:

Description

This PR normalizes log severity levels for the GCL sink based on GCL's standard referenced below.
The severity level of audit logs is INFO.

Ref: https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry#logseverity

/cc @cahartma @vparfonov
/assign @jcantrill

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Clee2691
Copy link
Contributor Author

/cherry-pick master

@openshift-cherrypick-robot

@Clee2691: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Oct 29, 2024

@Clee2691: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Clee2691, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a047172 into openshift:release-6.0 Oct 30, 2024
7 checks passed
@openshift-cherrypick-robot

@Clee2691: new pull request created: #2855

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants