LOG-6348: Collector startup script removes buffer lock files breaking locking code of vector #2912
Conversation
… locking code of vector
openshift-ci-robot
added
the
jira/valid-reference
|
@Clee2691: This pull request references LOG-6348 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
/cherry-pick release-6.1 |
|
@Clee2691: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
@Clee2691: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| # The directory used for persisting Vector state, such as on-disk buffers, file checkpoints, and more. | ||
| VECTOR_DATA_DIR=%s | ||
| echo "Creating the directory used for persisting Vector state $VECTOR_DATA_DIR" | ||
| mkdir -p ${VECTOR_DATA_DIR} |
There was a problem hiding this comment.
If I have seen this correctly, then the data directory is the base of a VolumeMount in the current configuration, meaning that it will always exist. If that is actually the case, I think it would be safe to completely remove the startup script and directly use vector as the entrypoint for the container.
There was a problem hiding this comment.
The operator passes in the datadir and there actually is a conditional of the value based upon the "legacy" naming convention and other. This behavior persists to support 'upgrade' behavior.
There was a problem hiding this comment.
As far as I can see the path can either be /var/lib/vector or /var/lib/vector/<namespace>/<instance>, but in both cases the path is directly used as the VolumeMount (code). I don't think the mkdir and thus the script is needed.
(But it's not directly related to this change, so consider my remarks optional)
There was a problem hiding this comment.
I'm inclined to leave this as is and we can revisit the start up script in another scope (JIRA)
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Clee2691, jcantrill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 3335c42
into
openshift:release-6.0
|
@Clee2691: new pull request created: #2928 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Clee2691: new pull request created: #2929 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Description
This PR removes the deletion of the buffer lock files in
vector's startup script./cc @cahartma @vparfonov
/assign @jcantrill
Links