Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped #580

alanconway · 2020-06-29T19:12:39Z

No description provided.

ewolinetz · 2020-06-29T21:48:12Z

are there other implications from this? does it change the operator RBAC at all?

alanconway · 2020-06-29T22:16:29Z

are there other implications from this? does it change the operator RBAC at all?

Not sure, are there any additional tests we should run to make sure it's OK?

alanconway · 2020-06-29T22:17:11Z

/retest
apparently the "v2" error is a CI platform flake.

periklis · 2020-06-30T08:49:53Z

@alanconway @ewolinetz I don't see a showstopper regarding RBAC. However, passing namespaces to the manager in main.go could be: https://sdk.operatorframework.io/docs/crds-scope/#crd-cluster-scoped-usage --> Is this an issue?

alanconway · 2020-06-30T18:31:48Z

/retest

jcantrill · 2020-07-09T11:15:15Z

/hold

jcantrill · 2020-07-09T11:16:19Z

@alanconway I rebased in a separate commit to see if tests would pass but please collapse this change into a single commit

alanconway · 2020-07-27T20:52:44Z

@alanconway @ewolinetz I don't see a showstopper regarding RBAC. However, passing namespaces to the manager in main.go could be: https://sdk.operatorframework.io/docs/crds-scope/#crd-cluster-scoped-usage --> Is this an issue?

@periklis That URL has been broken, I found this one: https://sdk.operatorframework.io/docs/legacy-common/operator-scope/
Does it cover the same issue?

periklis · 2020-07-28T07:55:46Z

@alanconway @ewolinetz I don't see a showstopper regarding RBAC. However, passing namespaces to the manager in main.go could be: https://sdk.operatorframework.io/docs/crds-scope/#crd-cluster-scoped-usage --> Is this an issue?

@periklis That URL has been broken, I found this one: https://sdk.operatorframework.io/docs/legacy-common/operator-scope/
Does it cover the same issue?

Yes, in detail: https://sdk.operatorframework.io/docs/legacy-common/operator-scope/#changes-required-for-a-cluster-scoped-operator

periklis

In general LGTM, I have only one concern regarding WATCH_NAMESPACE widening and ClusterLogging CRs.

docs/HACKING.md

manifests/4.6/cluster-logging.v4.6.0.clusterserviceversion.yaml

ewolinetz · 2020-07-30T21:27:40Z

before I give this a /lgtm e2e tests need to be addressed (they're failing as a result of changes in this PR)

HACKING.md

README.md

alanconway · 2020-07-31T20:21:43Z

@jcantrill I removed all the README/HACKING stuff, can you LGTM the cluster scope change?
I'll make a new PR for the other bits when I've reviewed your comments.

jcantrill · 2020-08-01T00:33:36Z

/retest

jcantrill · 2020-08-19T13:14:00Z

/retest

jcantrill

/lgtm

openshift-ci-robot · 2020-08-19T16:51:01Z

@alanconway: This pull request references Bugzilla bug 1870289, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alanconway · 2020-08-19T17:51:50Z

/bugzilla refresh

openshift-ci-robot · 2020-08-19T17:51:56Z

@alanconway: This pull request references Bugzilla bug 1870289, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcantrill · 2020-08-19T19:00:39Z

/retest

jcantrill · 2020-08-20T19:39:03Z

/lgtm

openshift-ci-robot · 2020-08-20T19:39:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alanconway · 2020-08-20T19:39:50Z

/hold cancel

openshift-ci-robot · 2020-08-20T20:12:46Z

@alanconway: All pull requests linked via external trackers have merged: openshift/cluster-logging-operator#580. Bugzilla bug 1870289 has been moved to the MODIFIED state.

In response to this:

Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped

openshift-ci-robot requested review from jcantrill and lukas-vlcek June 29, 2020 19:12

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 4, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020

alanconway force-pushed the clf-scope-clustered branch from a60c406 to 065edf7 Compare July 27, 2020 18:53

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2020

alanconway force-pushed the clf-scope-clustered branch 2 times, most recently from 1c6e053 to e8aeba4 Compare July 28, 2020 20:28

periklis suggested changes Jul 29, 2020

View reviewed changes

docs/HACKING.md Outdated Show resolved Hide resolved

manifests/4.6/cluster-logging.v4.6.0.clusterserviceversion.yaml Outdated Show resolved Hide resolved

alanconway force-pushed the clf-scope-clustered branch from e8aeba4 to 8e4e4a1 Compare July 30, 2020 17:31

alanconway force-pushed the clf-scope-clustered branch from 8e4e4a1 to e34371e Compare July 30, 2020 21:30

jcantrill added the release/4.6 label Jul 31, 2020

jcantrill reviewed Jul 31, 2020

View reviewed changes

HACKING.md Outdated Show resolved Hide resolved

HACKING.md Outdated Show resolved Hide resolved

HACKING.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

alanconway force-pushed the clf-scope-clustered branch 2 times, most recently from 19ab2f8 to d707bb8 Compare July 31, 2020 20:20

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020

jcantrill reviewed Aug 19, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020

alanconway force-pushed the clf-scope-clustered branch from 87d3d34 to 4889d53 Compare August 19, 2020 16:12

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2020

alanconway force-pushed the clf-scope-clustered branch from 4889d53 to 02d449a Compare August 19, 2020 16:16

alanconway changed the title ~~LOG-755: Make ClusterLogForwarder cluster scoped~~ Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped Aug 19, 2020

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Aug 19, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 19, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Aug 19, 2020

alanconway force-pushed the clf-scope-clustered branch 2 times, most recently from f82dbf7 to 4c6a679 Compare August 20, 2020 14:11

LOG-755: Make ClusterLogForwarder cluster scoped

2d736ef

alanconway force-pushed the clf-scope-clustered branch from 4c6a679 to 2d736ef Compare August 20, 2020 17:32

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2020

openshift-merge-robot merged commit 59a1ee2 into openshift:master Aug 20, 2020

alanconway deleted the clf-scope-clustered branch August 21, 2020 06:25

jcantrill mentioned this pull request Aug 25, 2020

Bug 1870898: Revert WATCH_NAMESPACE to unbreak clusterlogging #673

Merged

pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022

Merge pull request openshift#580 from alanconway/clf-scope-clustered

f0de7b3

Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped

Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped #580

Bug 1870289: LOG-755: Make ClusterLogForwarder cluster scoped #580

Uh oh!

Conversation

alanconway commented Jun 29, 2020

Uh oh!

ewolinetz commented Jun 29, 2020

Uh oh!

alanconway commented Jun 29, 2020

Uh oh!

alanconway commented Jun 29, 2020

Uh oh!

periklis commented Jun 30, 2020

Uh oh!

alanconway commented Jun 30, 2020

Uh oh!

jcantrill commented Jul 9, 2020

Uh oh!

jcantrill commented Jul 9, 2020

Uh oh!

alanconway commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

periklis commented Jul 28, 2020

Uh oh!

periklis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ewolinetz commented Jul 30, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alanconway commented Jul 31, 2020

Uh oh!

jcantrill commented Aug 1, 2020

Uh oh!

jcantrill commented Aug 19, 2020

Uh oh!

jcantrill left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Aug 19, 2020

Uh oh!

alanconway commented Aug 19, 2020

Uh oh!

openshift-ci-robot commented Aug 19, 2020

Uh oh!

jcantrill commented Aug 19, 2020

Uh oh!

jcantrill commented Aug 20, 2020

Uh oh!

openshift-ci-robot commented Aug 20, 2020

Uh oh!

alanconway commented Aug 20, 2020

Uh oh!

openshift-ci-robot commented Aug 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

alanconway commented Jul 27, 2020 •

edited

Loading