Skip to content

Conversation

@vimalk78
Copy link
Contributor

@vimalk78 vimalk78 commented Aug 25, 2020

Earlier implementation of application namespace filtering was based on selectively scrapping logs for namespaces in CLF spec.inputs.application.namespaces
CLF approach is to scrape all container logs, and then generate fluent conf according to the CLF spec.pipeline.
Now if namespaces are specified in spec.inputs.application, then filter is used to send only the namespace logs to pipeline.

The logic for dispatching application logs is:

if .CollectAppLogs
  if .AppNamespace
    <match $ns>  // tags for namespace only
      @type relabel
      @label @_APPLICATION
    </match>
  else
    <match k8s.**>
      @type relabel
      @label @_APPLICATION
    </match>      
  fi
else
    <match k8s.**>
      @null
    </match>
fi

/cc @alanconway @jcantrill

Earlier implementation of application namespace filtering was based on selectively scrapping logs for namespaces in CLF spec.inputs.application.namespaces
CLF approach is to scrape all container logs, and then generate fluent conf according to the CLF spec.pipeline.
Now if namespaces are specified in spec.inputs.application, then <match> filter is used to send only the namespace logs to pipeline.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 25, 2020
@openshift-ci-robot
Copy link

@vimalk78: This pull request references Bugzilla bug 1862367, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1862367: fixed application namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 25, 2020
@openshift-ci-robot
Copy link

@vimalk78: This pull request references Bugzilla bug 1862367, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1862367: fixed application namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

3 similar comments
@openshift-ci-robot
Copy link

@vimalk78: This pull request references Bugzilla bug 1862367, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1862367: fixed application namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@vimalk78: This pull request references Bugzilla bug 1862367, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1862367: fixed application namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@vimalk78: This pull request references Bugzilla bug 1862367, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1862367: fixed application namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3488a63 into openshift:master Aug 25, 2020
@openshift-ci-robot
Copy link

@vimalk78: All pull requests linked via external trackers have merged:

Bugzilla bug 1862367 has been moved to the MODIFIED state.

In response to this:

Bug 1862367: fixed application namespace filtering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
Bug 1862367: fixed application namespace filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants