-
Notifications
You must be signed in to change notification settings - Fork 167
Bug 1862367: fixed application namespace filtering #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Earlier implementation of application namespace filtering was based on selectively scrapping logs for namespaces in CLF spec.inputs.application.namespaces CLF approach is to scrape all container logs, and then generate fluent conf according to the CLF spec.pipeline. Now if namespaces are specified in spec.inputs.application, then <match> filter is used to send only the namespace logs to pipeline.
|
@vimalk78: This pull request references Bugzilla bug 1862367, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vimalk78: This pull request references Bugzilla bug 1862367, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 similar comments
|
@vimalk78: This pull request references Bugzilla bug 1862367, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vimalk78: This pull request references Bugzilla bug 1862367, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vimalk78: This pull request references Bugzilla bug 1862367, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
alanconway
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alanconway, vimalk78 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vimalk78: All pull requests linked via external trackers have merged: Bugzilla bug 1862367 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Bug 1862367: fixed application namespace filtering
Earlier implementation of application namespace filtering was based on selectively scrapping logs for namespaces in CLF spec.inputs.application.namespaces
CLF approach is to scrape all container logs, and then generate fluent conf according to the CLF spec.pipeline.
Now if namespaces are specified in spec.inputs.application, then filter is used to send only the namespace logs to pipeline.
The logic for dispatching application logs is:
/cc @alanconway @jcantrill