Bug 1874746: Fixed ClusterLogging CR status

[vimalk78]

• removed crd generation patch which was making an empty status in CRD
• fixed package name for ClusterConditions type. This was causing generated CRD to have a $ref field, which fails validation
• updated clusterlogging status in clusterlogging controller at the end of Reconcile function
• fixed elasticsearch pod state to return empty array if status not available for a state type, this was causing error like status.logStore.elasticsearchStatus.pods.client.failed in body must be of type array

Getting status as:

status:
  clusterConditions:
  - lastTransitionTime: "2020-09-08T20:54:00Z"
    status: "False"
    type: CollectorDeadEnd
  collection:
    logs:
      fluentdStatus:
        daemonSet: fluentd
        nodes:
          fluentd-hzjk7: crc-fd5nx-master-0
        pods:
          failed: []
          notReady: []
          ready:
          - fluentd-hzjk7
  curation:
    curatorStatus:
    - cronJobs: curator
      schedules: 30 3 * * *
      suspended: false
  logStore:
    elasticsearchStatus:
    - cluster:
        activePrimaryShards: 4
        activeShards: 4
        initializingShards: 0
        numDataNodes: 1
        numNodes: 1
        pendingTasks: 0
        relocatingShards: 0
        status: green
        unassignedShards: 0
      clusterName: elasticsearch
      nodeConditions:
        elasticsearch-cdm-jbh1itbd-1: []
      nodeCount: 1
      pods:
        client:
          failed: []                                                                                                                                                                                                                          
          notReady: []                                                                                                                                                                                                                        
          ready:                                                                                                                                                                                                                              
          - elasticsearch-cdm-jbh1itbd-1-f85c6ddd5-jgdsz                                                                                                                                                                                      
        data:                                                                                                                                                                                                                                 
          failed: []                                                                                                                                                                                                                          
          notReady: []                                                                                                                                                                                                                        
          ready:                                                                                                                                                                                                                              
          - elasticsearch-cdm-jbh1itbd-1-f85c6ddd5-jgdsz                                                                                                                                                                                      
        master:                                                                                                                                                                                                                               
          failed: []                                                                                                                                                                                                                          
          notReady: []                                                                                                                                                                                                                        
          ready:                                                                                                                                                                                                                              
          - elasticsearch-cdm-jbh1itbd-1-f85c6ddd5-jgdsz                                                                                                                                                                                      
      shardAllocationEnabled: all                                                                                                                                                                                                             
  visualization: {}  

/assign @jcantrill
/cc @alanconway

[openshift-ci-robot]

@vimalk78: This pull request references Bugzilla bug 1874746, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1874746: Fixed ClusterLogging CR status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[alanconway]

/lgtm
/approve

[jcantrill]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@vimalk78: This pull request references Bugzilla bug 1874746, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1874746: Fixed ClusterLogging CR status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@vimalk78: All pull requests linked via external trackers have merged:

• openshift/cluster-logging-operator#691

Bugzilla bug 1874746 has been moved to the MODIFIED state.

In response to this:

Bug 1874746: Fixed ClusterLogging CR status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.