Skip to content

Bug 1903912: Deploy fluent init container when logstore.nodecount > 0 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2021
Merged

Bug 1903912: Deploy fluent init container when logstore.nodecount > 0 #840

merged 1 commit into from
Jan 8, 2021

Conversation

@jcantrill
Copy link
Contributor

@jcantrill jcantrill commented Dec 15, 2020

Description

This PR only deploys an init container for fluentd if the logstore has a node count greater then 0

/cc @igor-karpukhin @vimalk78
/assign @alanconway

/cherry-pick

Links

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 15, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2020

@jcantrill: This pull request references Bugzilla bug 1903912, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1903912: Deploy fluent init container when logstore.nodecount > 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill added release/4.7 and removed bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 15, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020
alanconway
alanconway reviewed Dec 16, 2020
View reviewed changes
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 8, 2021

/refresh

@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 8, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2021

@jcantrill: This pull request references Bugzilla bug 1903912, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 8, 2021
@jcantrill
Copy link
Contributor Author

jcantrill commented Jan 8, 2021

/cherrypick release-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 8, 2021

@jcantrill: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit b8d8172 into openshift:master Jan 8, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 8, 2021

@jcantrill: All pull requests linked via external trackers have merged:

Bugzilla bug 1903912 has been moved to the MODIFIED state.

In response to this:

Bug 1903912: Deploy fluent init container when logstore.nodecount > 0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 8, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 8, 2021

@jcantrill: new pull request created: #850

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pmoogi-redhat pushed a commit to pmoogi-redhat/cluster-logging-operator that referenced this pull request Apr 26, 2022
@openshift-merge-robot
Merge pull request openshift#840 from jcantrill/1903912
5b2aec8 
Bug 1903912: Deploy fluent init container when logstore.nodecount > 0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igor-karpukhin igor-karpukhin Awaiting requested review from igor-karpukhin

@vimalk78 vimalk78 Awaiting requested review from vimalk78

1 more reviewer

@alanconway alanconway alanconway left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alanconway alanconway

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. release/4.7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jcantrill @openshift-ci-robot @openshift-bot @openshift-cherrypick-robot @alanconway @openshift-merge-robot