Skip to content

OCPBUGS-46422: Add a ValidatingAdmissionPolicy blocking ServiceCIDR changes [4.20] #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.20
Choose a base branch
from
Open

OCPBUGS-46422: Add a ValidatingAdmissionPolicy blocking ServiceCIDR changes [4.20] #2827

wants to merge 1 commit into from

Conversation

@danwinship
Copy link
Contributor

backport of #2797
note that this won't pass CI until openshift/kubernetes#2466 merges but it can still be lgtm'ed before then

@danwinship
Add a ValidatingAdmissionPolicy blocking ServiceCIDR changes
a984a49 
OCP does not yet support changing the service CIDRs at runtime.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

backport of #2797
note that this won't pass CI until openshift/kubernetes#2466 merges but it can still be lgtm'ed before then

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danwinship danwinship changed the base branch from master to release-4.20 October 28, 2025 14:37
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 28, 2025
@openshift-ci-robot
Copy link
Contributor

@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-61196 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-61196 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

backport of #2797
note that this won't pass CI until openshift/kubernetes#2466 merges but it can still be lgtm'ed before then

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
@danwinship danwinship mentioned this pull request Oct 28, 2025
Open
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade a984a49 link false /test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
ci/prow/security a984a49 link false /test security
ci/prow/4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade a984a49 link false /test 4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade a984a49 link false /test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-ovn-upgrade a984a49 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw a984a49 link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/okd-scos-e2e-aws-ovn a984a49 link false /test okd-scos-e2e-aws-ovn
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade a984a49 link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade a984a49 link false /test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw a984a49 link true /test e2e-metal-ipi-ovn-dualstack-bgp-local-gw
ci/prow/e2e-aws-ovn-windows a984a49 link true /test e2e-aws-ovn-windows
ci/prow/e2e-ovn-ipsec-step-registry a984a49 link true /test e2e-ovn-ipsec-step-registry
ci/prow/security a984a49 link false /test security
ci/prow/4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade a984a49 link false /test 4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danwinship
Copy link
Contributor Author

/label backport-risk-assessed
/assign @kyrtapz @bpickard22
this is the same as #2797 / #2605, just on release-4.20

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@arghosh93 arghosh93 Awaiting requested review from arghosh93

@bpickard22 bpickard22 Awaiting requested review from bpickard22

Assignees

@eurijon eurijon

@kyrtapz kyrtapz

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@bpickard22 bpickard22

@imatza-rh imatza-rh

@Meina-rh Meina-rh

@barbora137 barbora137

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.