PPC: verify core with the same ID always has same sibling list and add missing test #1235
Conversation
So far PPC checked that compared sockets are identical in terms of Core ID, threads' number and logical processors list. The scope and importance of the Core ID is mainly within the single socket (numa/dei) and by tracking it we can know the siblings list for a specific core ID. Add missing negative unit test for `ensureSameTopology()` where it contructs 2 compute nodes that are completely identical, while on NUMA level there are cores with different siblings list. This should be reporting an error but it will fail because the verification logic is not checked but will follow next. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shajmakh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Or in other words, verify that siblings CPUs are associated with same core id on NUMA level. Core ID (from `/sys/devices/system/node/nodeX/cpuY/topology/core_id`) is important especially for the specific NUMA, and CPUs siblings are featured by that they have same core id. Although this rarely happens in real computers, PPC tool depends on the data reported by the must-gather, so we need to verify that what's received is still preserving the accepted configuration for generating a performance-profile. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
shajmakh
force-pushed
the
ppc-missed-check
branch
from
7dbf15e to
3504d8a
Compare
|
/retest |
|
@shajmakh: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
In other words, verify that siblings CPUs are associated with same
core id on NUMA level.
Core ID (from
/sys/devices/system/node/nodeX/cpuY/topology/core_id) isimportant especially for the specific NUMA, and CPUs siblings are
featured by that they have same core id. Although this rarely happens in
real computers, PPC tool depends on the data reported by the
must-gather, so we need to verify that what's received is still
preserving the accepted configuration for generating a
performance-profile. Additionally add unit tests to cover this behavior.