Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Oct 15, 2025

So it's clear that we're waiting on the bundle, when that's what's happening. Currently there's a risk that we block silently forever when the CA bundle is not supplied.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2025
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request explicitly references no jira issue.

In response to this:

So it's clear that we're waiting on the bundle, when that's what's happening. Currently there's a risk that we block silently forever when the CA bundle is not supplied.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Tal-or and ffromani October 15, 2025 16:29
So it's clear that we're waiting on the bundle, when that's what's
happening.  Currently there's a risk that we block silently forever
when the CA bundle is not supplied.
@wking
Copy link
Member Author

wking commented Oct 15, 2025

/retest-required

1 similar comment
@wking
Copy link
Member Author

wking commented Oct 20, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

@wking: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 97bd96c link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wking
Copy link
Member Author

wking commented Oct 29, 2025

/retest-required

@jmencak
Copy link
Contributor

jmencak commented Oct 30, 2025

/lgtm
/verified later @liqcui

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Oct 30, 2025
@jmencak
Copy link
Contributor

jmencak commented Oct 30, 2025

/approve

@openshift-ci-robot
Copy link
Contributor

@jmencak: This PR has been marked to be verified later by @liqcui.

In response to this:

/lgtm
/verified later @liqcui

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit bca7572 into openshift:main Oct 30, 2025
18 of 19 checks passed
@wking wking deleted the metrics-log-client-CA-handling branch October 30, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants