-
Notifications
You must be signed in to change notification settings - Fork 116
NO-ISSUE: pkg/metrics/server: Log client-CA-bundle handling #1412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: pkg/metrics/server: Log client-CA-bundle handling #1412
Conversation
|
@wking: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
So it's clear that we're waiting on the bundle, when that's what's happening. Currently there's a risk that we block silently forever when the CA bundle is not supplied.
|
/retest-required |
1 similar comment
|
/retest-required |
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
|
/lgtm |
|
/approve |
|
@jmencak: This PR has been marked to be verified later by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bca7572
into
openshift:main
So it's clear that we're waiting on the bundle, when that's what's happening. Currently there's a risk that we block silently forever when the CA bundle is not supplied.