Skip to content

[release-4.1] Do not update service account when it is already created. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2019
Merged

[release-4.1] Do not update service account when it is already created. #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pkg/controller/tuned/tuned_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,8 @@ func (r *ReconcileTuned) syncServiceAccount(tuned *tunedv1.Tuned) error {
return fmt.Errorf("Failed to get ServiceAccount: %v\n", err)
}
} else {
glog.V(2).Infof("Tuned ServiceAccount already exists, updating")
err = r.client.Update(context.TODO(), saManifest)
if err != nil {
return fmt.Errorf("Couldn't update tuned ServiceAccount: %v", err)
}
// Do not update service account as it leads to accumulating secrets; see BZ1714484
glog.V(2).Infof("Tuned ServiceAccount already exists, skipping update")
}

return nil
Expand Down