Skip to content

Conversation

@jmencak
Copy link
Contributor

@jmencak jmencak commented Jun 24, 2019

@openshift-ci-robot
Copy link
Contributor

@jmencak: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1719967: Implement leader-for-life election.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 24, 2019
@openshift-ci-robot openshift-ci-robot requested a review from sjug June 24, 2019 15:43
@jmencak
Copy link
Contributor Author

jmencak commented Jun 26, 2019

@zvonkok , mind taking a look in Sebastian's absence? Thanks!

@zvonkok
Copy link

zvonkok commented Jun 26, 2019

The same approach as here: https://github.com/zvonkok/special-resource-operator/blob/a065b27c1aa9219b3960a8ea47069754a5533920/cmd/manager/main.go#L56
and this works if multiple instances of the operator are running, one is leader and the other ones are "only" waiting to become leader.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmencak, zvonkok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmencak
Copy link
Contributor Author

jmencak commented Jun 26, 2019

/uncc @sjug

@openshift-ci-robot openshift-ci-robot removed the request for review from sjug June 26, 2019 13:56
@openshift-merge-robot openshift-merge-robot merged commit 8d682b0 into openshift:master Jun 26, 2019
@jmencak
Copy link
Contributor Author

jmencak commented Jun 26, 2019

/cherrypick release-4.1

@openshift-cherrypick-robot

@jmencak: new pull request created: #68

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak changed the title Bug 1719967: Implement leader-for-life election. Implement leader-for-life election. Jun 26, 2019
@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jun 26, 2019
@openshift-ci-robot
Copy link
Contributor

@jmencak: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Implement leader-for-life election.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmencak jmencak deleted the leader branch October 9, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants