donotmerge: testing finalizer removal (pull secrets) #384
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardomaraschini The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ricardomaraschini
force-pushed
the
temp-remove-finalizers-4.16
branch
3 times, most recently
from
e4b9557 to
9b050c0
Compare
sanchezl
left a comment
sanchezl
left a comment
There was a problem hiding this comment.
On the right track, but this would still leave the possibility of some token secrets being missed if the SA->ImagePullSecret->TokenSecret connections are not there. Consider bringing in the legacyImagePullSecretRollbackController into the OCM-o and running it in parallel.
| // once the image registry is disabled we want to wait unil the controller manager | ||
| // operand is deployed and stable before clean up the image pull secrets. we don't | ||
| // want to compete with the operand that may be acting on the same resources we are. |
There was a problem hiding this comment.
There is still a chance for the controllers to be out of sync here, but I do think that this is an improvement.
There was a problem hiding this comment.
Can you please elaborate a little bit more on the legacyImagePullSecretRollbackController matter ? It does not seem to be in use in the openshift-controller-manager project (I could not find where it is started there).
I failed to see how the controllers could be out of sync, can you give me more details ?
this pr should not be merged and is intended for testing.
ricardomaraschini
force-pushed
the
temp-remove-finalizers-4.16
branch
from
9b050c0 to
40a6d88
Compare
|
This one is being superseded by #382 |
2 participants
this pr should not be merged and is intended for testing.