Skip to content

Conversation

@vincentdephily
Copy link
Contributor

  • Select the desired kubernetes release branch, and use its go.mod and CHANGELOG as references for the rest of the work.
  • Bump go version, all k8s.io/, github.com/openshift/, and any other relevant dependencies as needed.
  • Run go mod vendor && go mod tidy, commit that separately from all other changes.
  • Bump image versions (Dockerfile, ci...) if needed.
  • Run make build verify test.
  • Make code changes as needed until the above pass.
  • Any other minor update, like documentation.

…ogle/go-cmp/cmp

The former is deprecated in favor of the later in k8s 1.33, and
removed in 1.34.

Output looks the same in a trivial manual test, but this is only used
for diagnosing test failures anyway so differences would not be an
issue.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2025

@vincentdephily: This pull request references CNTRLPLANE-1676 which is a valid jira issue.

In response to this:

  • Select the desired kubernetes release branch, and use its go.mod and CHANGELOG as references for the rest of the work.
  • Bump go version, all k8s.io/, github.com/openshift/, and any other relevant dependencies as needed.
  • Run go mod vendor && go mod tidy, commit that separately from all other changes.
  • Bump image versions (Dockerfile, ci...) if needed.
  • Run make build verify test.
  • Make code changes as needed until the above pass.
  • Any other minor update, like documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from atiratree and deads2k November 20, 2025 11:09
@vincentdephily
Copy link
Contributor Author

/assign @ingvagabund

@vincentdephily
Copy link
Contributor Author

Since the code change was for a previously deprecated API, I did it as the first commit.

Checklist inspired from #164, but tweaked for my tastes, could probably get refined.

@ingvagabund
Copy link
Member

/retest-required

@ingvagabund
Copy link
Member

/approve
/lgtm

@ingvagabund
Copy link
Member

/verified by CI

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2025
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 20, 2025
@openshift-ci-robot
Copy link
Contributor

@ingvagabund: This PR has been marked as verified by CI.

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, vincentdephily

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ef70396 and 2 for PR HEAD a082c48 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

@vincentdephily: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8b77548 into openshift:main Nov 20, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants