-
Notifications
You must be signed in to change notification settings - Fork 49
CNTRLPLANE-1676: Update to Kubernetes v1.34.2 #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNTRLPLANE-1676: Update to Kubernetes v1.34.2 #170
Conversation
…ogle/go-cmp/cmp The former is deprecated in favor of the later in k8s 1.33, and removed in 1.34. Output looks the same in a trivial manual test, but this is only used for diagnosing test failures anyway so differences would not be an issue.
|
@vincentdephily: This pull request references CNTRLPLANE-1676 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @ingvagabund |
|
Since the code change was for a previously deprecated API, I did it as the first commit. Checklist inspired from #164, but tweaked for my tastes, could probably get refined. |
|
/retest-required |
|
/approve |
|
/verified by CI |
|
@ingvagabund: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund, vincentdephily The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vincentdephily: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
go.modandCHANGELOGas references for the rest of the work.k8s.io/,github.com/openshift/, and any other relevant dependencies as needed.go mod vendor && go mod tidy, commit that separately from all other changes.make build verify test.