Skip to content

CONSOLE-3397: Remove managed cluster API server data from managed clu… #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

CONSOLE-3397: Remove managed cluster API server data from managed clu… #708

wants to merge 1 commit into from

Conversation

TheRealJon
Copy link
Member

…ster configs

@openshift-ci openshift-ci bot requested review from jhadvig and spadgett December 15, 2022 18:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
jhadvig
jhadvig approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jhadvig
Copy link
Member

jhadvig commented Dec 16, 2022

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@christoph-jerolimov
Copy link
Member

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@jhadvig
Copy link
Member

jhadvig commented Dec 20, 2022 

--- FAIL: TestUnmanaged (37.21s)

/retest

@TheRealJon
CONSOLE-3397: Remove managed cluster API server data from managed clu…
54bc840 
…ster configs

Signed-off-by: Jon Jackson <jonjacks@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jhadvig
jhadvig approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented Jan 3, 2023

QE Approver:

/assign @yapei
Docs Approver:

/assign @opayne1
PX Approver:

/assign @RickJWagner

@jhadvig
Copy link
Member

jhadvig commented Jan 3, 2023

@TheRealJon once this PR is merged we should open a console PR that will update serverconfig types accordingly.

@opayne1
Copy link
Contributor

opayne1 commented Jan 3, 2023

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jan 3, 2023
@RickJWagner
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jan 3, 2023
@TheRealJon
Copy link
Member Author

/hold

QE feedback

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2023
@TheRealJon
Copy link
Member Author

Closing as the console backend still uses API server URL and CA data to configure auth.

@TheRealJon TheRealJon closed this Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TheRealJon @jhadvig @christoph-jerolimov @opayne1 @RickJWagner