Show a '<1ms' notice in the table for small trace durations #20
Conversation
openshift-ci
bot
added
the
approved
|
@PeterYurkovich: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.1 |
|
@jgbernalp: new pull request created: #23 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Perses doesn't currently provide support for traces which take less than 1ms. The duration is left blank in their datastore and the spans are not left available, meaning that the duration can't be calculated from the spans either.
In order to solve this problem, upstream work on Perses is required. However, to get the distributed tracing plugin in working order for its release, we will add an additional description in the table to show that the trace took less than 1 millisecond so that users will know what the data is, even if it isn't specific enough currently.
This PR does not impact the scatterplot, which will continue to be left looking blank when these short traces happen. If desired, we could remove the graph when this happens, but until upstream work is completed that is the most we can do.