Bug 1725148: Updating to not set CPU limit unless it is explicitly set

[ewolinetz]

Previously we were setting the CPU limit to match the CPU request if the request was provided but the limit was not. This removes the logic to set the CPU limit for ES nodes unless it is explicitly defined.

[openshift-ci-robot]

@ewolinetz: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state.

In response to this:

[WIP] Bug 1725148: Updating to not set CPU limit unless it is explicitly set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ewolinetz]

@jcantrill please review the TC in common_test.go to verify all the scenarios we cover with respect to resources and merging. In this PR we will still set your Mem Limit to be the same as your Mem Request if the limit is omitted (for performance reasons of not needing to reallocate memory to the container and let it grow until the node stops it).

We will also set the request values if only limit is specified.

[jcantrill]

aside from a few comment nits LGTM

[ewolinetz]

/retest

[openshift-ci-robot]

@ewolinetz: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state.

In response to this:

Bug 1725148: Updating to not set CPU limit unless it is explicitly set

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jcantrill]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment