Skip to content

Bug 1833145: Set network policy when doing upgrades to prevent connections #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2020
Merged

Bug 1833145: Set network policy when doing upgrades to prevent connections #347

merged 1 commit into from
May 26, 2020

Conversation

ewolinetz
Copy link
Contributor

@ewolinetz ewolinetz commented May 6, 2020 •
edited
Loading

This will allow the Elasticsearch Operator to prevent ingress traffic to the ES cluster on port 9200 from anywhere other than the Elasticsearch Operator pod itself.

This should assist in the upgrade process as we will be able to halt logs flowing in.

Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1833145

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2020
@ewolinetz
Copy link
Contributor Author

/retest

@ewolinetz ewolinetz force-pushed the network_policy_es branch 2 times, most recently from f7e4e3a to 5e8a8bf Compare May 7, 2020 21:44
@ewolinetz ewolinetz changed the title [WIP] Set network policy when doing upgrades to prevent connections Bug 1833145: Set network policy when doing upgrades to prevent connections May 7, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 7, 2020
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references Bugzilla bug 1833145, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1833145: Set network policy when doing upgrades to prevent connections

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ewolinetz
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020
@ewolinetz
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 7, 2020
@openshift-ci-robot
Copy link

@ewolinetz: This pull request references Bugzilla bug 1833145, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 7, 2020
periklis
periklis reviewed May 12, 2020
View reviewed changes
@ewolinetz
Copy link
Contributor Author

/retest

1 similar comment
@ewolinetz
Copy link
Contributor Author

/retest

jcantrill
jcantrill requested changes May 19, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2020
@ewolinetz ewolinetz force-pushed the network_policy_es branch from 5e8a8bf to fc97673 Compare May 20, 2020 14:16
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2020
@ewolinetz
Copy link
Contributor Author

/retest

@ewolinetz ewolinetz force-pushed the network_policy_es branch 3 times, most recently from cdd1492 to 2c00a6a Compare May 20, 2020 18:23
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2020
@ewolinetz ewolinetz force-pushed the network_policy_es branch from 2c00a6a to 262f606 Compare May 21, 2020 16:25
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2020
@ewolinetz
Copy link
Contributor Author

/retest

periklis
periklis approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2020
@jcantrill
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ewolinetz
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcantrill
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 245fb3f into openshift:master May 26, 2020
@openshift-ci-robot
Copy link

@ewolinetz: All pull requests linked via external trackers have merged: openshift/elasticsearch-operator#347. Bugzilla bug 1833145 has been moved to the MODIFIED state.

In response to this:

Bug 1833145: Set network policy when doing upgrades to prevent connections

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor

/retest

@ewolinetz ewolinetz deleted the network_policy_es branch December 1, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill jcantrill requested changes

@igor-karpukhin igor-karpukhin Awaiting requested review from igor-karpukhin

+1 more reviewer

@periklis periklis periklis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@periklis periklis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ewolinetz @openshift-ci-robot @jcantrill @openshift-bot @periklis @openshift-merge-robot