Bug 1891666: LOG-900: Updating hacking docs and csv to be more up-to-date #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

openshift-merge-robot merged 1 commit into openshift:master from ewolinetz:fixup_csv_readme

Oct 31, 2020

Contributor

ewolinetz commented Oct 27, 2020 •

edited

Loading

Description

This PR:

Updates the csv example and correcting the Provider to match CLO.
Updates the docs/hacking.md file to be more relevant to the current development and deployment process with make targets
Minor typo in the pull_request_template

/cc @blockloop @periklis

Links

JIRA: https://issues.redhat.com/browse/LOG-900
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1891666

openshift-ci-robot requested review from blockloop and periklis

October 27, 2020 16:45

openshift-ci-robot added the approved label

periklis reviewed

View reviewed changes

Contributor

periklis left a comment

LGTM, minor changes. Keep In mind that you may need to apply the work in CSV after #529 is merged.

docs/HACKING.md Outdated Show resolved Hide resolved

docs/HACKING.md Outdated Show resolved Hide resolved

manifests/4.6/elasticsearch-operator.v4.6.0.clusterserviceversion.yaml Outdated Show resolved Hide resolved

ewolinetz force-pushed the fixup_csv_readme branch from 4583c08 to 0d1e22a Compare

October 27, 2020 18:43

ewolinetz changed the title ~~LOG-900: Updating hacking docs and csv to be more up-to-date~~ Bug 1891666: LOG-900: Updating hacking docs and csv to be more up-to-date

openshift-ci-robot added the bugzilla/severity-low label

openshift-ci-robot commented Oct 27, 2020 •

edited

Loading

@ewolinetz: This pull request references Bugzilla bug 1891666, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1891666: LOG-900: Updating hacking docs and csv to be more up-to-date

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/valid-bug label

Contributor Author

ewolinetz commented Oct 27, 2020

/hold
will need to go in after #529

openshift-ci-robot added the do-not-merge/hold label

ewolinetz force-pushed the fixup_csv_readme branch from 0d1e22a to 931ca48 Compare

October 27, 2020 18:49


          Updating hacking docs and csv to be more up-to-date

a8d8f6a

ewolinetz force-pushed the fixup_csv_readme branch from 931ca48 to a8d8f6a Compare

October 29, 2020 20:44

Contributor Author

ewolinetz commented Oct 29, 2020

/hold cancel

openshift-ci-robot removed the do-not-merge/hold label

blockloop approved these changes

View reviewed changes

Contributor

blockloop left a comment

/lgtm

openshift-ci-robot assigned blockloop

openshift-ci-robot added the lgtm label

openshift-ci-robot commented Oct 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, ewolinetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ewolinetz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Oct 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments

Contributor

openshift-bot commented Oct 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

periklis commented Oct 30, 2020

/uncc @periklis

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 30, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Oct 31, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit 05a6a61 into openshift:master

openshift-ci-robot commented Oct 31, 2020 •

edited

Loading

@ewolinetz: All pull requests linked via external trackers have merged:

openshift/elasticsearch-operator#552

Bugzilla bug 1891666 has been moved to the MODIFIED state.

In response to this:

Bug 1891666: LOG-900: Updating hacking docs and csv to be more up-to-date

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved bugzilla/severity-low bugzilla/valid-bug lgtm