Skip to content

Conversation

@sedroche
Copy link
Contributor

@sedroche sedroche commented Dec 17, 2020

Description

ElasticsearchClusterNotHealthy is one of the noisier alerts on OSD. After reviewing this alert we found that this alert "self resolves" most commonly after 5 minutes.
Setting this to 7 minutes should relieve this.

/cc @alanconway
/assign @ewolinetz

Links

@sedroche
Copy link
Contributor Author

/retest

Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue to figure out why this alert is coming up so often? Increasing the timeout might be a reasonable work-around, but it sounds like we should evaluate whether the alert itself should be removed or modified, or whether it's indicating something we need to fix.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@jcantrill
Copy link
Contributor

@sedroche you will need to create a bz for 4.7 and clone for 4.6 if the intention is to pull this change into these releases. It is the only way to satisfy the workflow

@sedroche sedroche changed the title Change ElasticsearchClusterNotHealthy to 7 minutes Bug 1908958: Change ElasticsearchClusterNotHealthy to 7 minutes Dec 18, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 18, 2020
@openshift-ci-robot
Copy link

@sedroche: This pull request references Bugzilla bug 1908958, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1908958: Change ElasticsearchClusterNotHealthy to 7 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 18, 2020
@sedroche
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@sedroche: This pull request references Bugzilla bug 1908958, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sedroche
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@sedroche: This pull request references Bugzilla bug 1908958, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 18, 2020
@sedroche
Copy link
Contributor Author

@sedroche you will need to create a bz for 4.7 and clone for 4.6 if the intention is to pull this change into these releases. It is the only way to satisfy the workflow

@jcantrill I have created a bz for 4.7 and 4.6
https://bugzilla.redhat.com/show_bug.cgi?id=1908958
https://bugzilla.redhat.com/show_bug.cgi?id=1908959

@openshift-ci-robot
Copy link

@sedroche: This pull request references Bugzilla bug 1908958, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1908958: Change ElasticsearchClusterNotHealthy to 7 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 18, 2020
@openshift-ci-robot
Copy link

@sedroche: This pull request references Bugzilla bug 1908958, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1908958: Change ElasticsearchClusterNotHealthy to 7 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sedroche
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 18, 2020
@openshift-ci-robot
Copy link

@sedroche: This pull request references Bugzilla bug 1908958, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sedroche
Copy link
Contributor Author

/test cluster-logging-operator-e2e

@sedroche
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@sedroche: This pull request references Bugzilla bug 1908958, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Dec 18, 2020
@openshift-merge-robot
Copy link
Contributor

@sedroche: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/cluster-logging-operator-e2e fbb197f link /test cluster-logging-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ewolinetz
Copy link
Contributor

/cc @blockloop @lukas-vlcek

@ewolinetz
Copy link
Contributor

@sedroche this looks to need a rebase

@sedroche sedroche force-pushed the refine-ElasticsearchClusterNotHealthy branch from fbb197f to 40a68d8 Compare January 7, 2021 22:42
@sedroche
Copy link
Contributor Author

sedroche commented Jan 7, 2021

/retest

1 similar comment
@sedroche
Copy link
Contributor Author

sedroche commented Jan 8, 2021

/retest

@sedroche
Copy link
Contributor Author

sedroche commented Jan 8, 2021

@ewolinetz rebased

@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, blockloop, ewolinetz, sedroche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [alanconway,ewolinetz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a7e01c2 into openshift:master Jan 9, 2021
@openshift-ci-robot
Copy link

@sedroche: All pull requests linked via external trackers have merged:

Bugzilla bug 1908958 has been moved to the MODIFIED state.

In response to this:

Bug 1908958: Change ElasticsearchClusterNotHealthy to 7 minutes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill
Copy link
Contributor

/cherrypick release-4.6

@openshift-cherrypick-robot

@jcantrill: #600 failed to apply on top of branch "release-4.6":

Applying: Change ElasticsearchClusterNotHealthy to 7 minutes
Using index info to reconstruct a base tree...
M	files/prometheus_alerts.yml
Falling back to patching base and 3-way merge...
Auto-merging files/prometheus_alerts.yml
CONFLICT (content): Merge conflict in files/prometheus_alerts.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Change ElasticsearchClusterNotHealthy to 7 minutes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants