Skip to content

LOG-1169: Fix no icon on EO in Operator Hub #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2021
Merged

LOG-1169: Fix no icon on EO in Operator Hub #663

merged 1 commit into from
Mar 5, 2021

Conversation

vimalk78
Copy link
Contributor

@vimalk78 vimalk78 commented Mar 3, 2021 •
edited by openshift-ci-robot
Loading

Description

LOG-1169: Fix no icon on EO in Operator Hub

  • Changed image type from image/svg to image/svg+xml

/cc
/assign @ewolinetz

/cherry-pick master

Links

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 3, 2021 •
edited
Loading

@vimalk78: GitHub didn't allow me to request PR reviews from the following users: vimalk78.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description

LOG-1169: Fix no icon on EO in Operator Hub

  • Changed image type from image/svg to image/svg+xml

/cc
/assign @ewolinetz

/cherry-pick master

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

periklis
periklis approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2021
@periklis
Copy link
Contributor

periklis commented Mar 3, 2021

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2021
@periklis
Copy link
Contributor

periklis commented Mar 3, 2021

/hold @vimalk78 You should now update the CSV neither in the bundle nor in the manifests directory for EO. The approach is to update the CSV config/manifests/bases and execute make bundle.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@vimalk78
LOG-1169: Fix no icon on EO in Operator Hub
1e568b0 
   - Changed image type from `image/svg` to `image/svg+xml`
@vimalk78
Copy link
Contributor Author

vimalk78 commented Mar 4, 2021

/hold @vimalk78 You should now update the CSV neither in the bundle nor in the manifests directory for EO. The approach is to update the CSV config/manifests/bases and execute make bundle.

Updated

periklis
periklis reviewed Mar 4, 2021
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@periklis
Copy link
Contributor

periklis commented Mar 4, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 4, 2021
@ewolinetz
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, periklis, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2021
@openshift-merge-robot openshift-merge-robot merged commit f434a0a into openshift:release-5.0 Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@periklis periklis periklis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@periklis periklis

@ewolinetz ewolinetz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vimalk78 @openshift-ci-robot @periklis @ewolinetz @openshift-merge-robot