Skip to content

LOG-1325: Troubleshooting doc improvement #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2021
Merged

LOG-1325: Troubleshooting doc improvement #712

merged 1 commit into from
May 13, 2021

Conversation

lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented May 10, 2021 •
edited
Loading

Description

Document use of Delete By Query API to delete set of logs from index. For example logs relevant to specific namespace only.

  • Add charts and dashboard example for Logs by namespace chapter
  • Add Delete By Query chapter

/cc @jcantrill
/assign @ewolinetz

Links

@openshift-ci openshift-ci bot requested a review from jcantrill May 10, 2021 13:57
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2021
lukas-vlcek
lukas-vlcek commented May 10, 2021
View reviewed changes
ewolinetz
ewolinetz approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@ewolinetz ewolinetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple nits, otherwise lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2021
@lukas-vlcek
Copy link
Contributor Author

lukas-vlcek commented May 11, 2021 •
edited
Loading

Got additional feedback from @sichvoge about clarification of expected "consequences" (the term I used in the text).

We should explain better what kind of resources are taken and when:
E.g.: The critical part is when segments are merged and this will take one CPU thread for the whole time (unless it is terminated/interrupted) and it will need additional disk space until all segments in question are merged together, only then it will release the disk space and the thread.
Those are the resources it takes and they will be missing in indexing pipeline in the meantime.

EDIT: Done.

@lukas-vlcek lukas-vlcek changed the title Troubleshooting doc improvement LOG-1325: Troubleshooting doc improvement May 11, 2021
@lukas-vlcek lukas-vlcek force-pushed the delete_logs branch 5 times, most recently from f67defc to dcc9663 Compare May 12, 2021 14:54
@lukas-vlcek
LOG-1325: Document use of Delete_By_Query
6d3c56a 
- Add charts and dashboard example for Logs by namespace chapter
- Add Delete By Query chapter
- Reorder chapters
@lukas-vlcek
Copy link
Contributor Author

/test e2e-upgrade

@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, lukas-vlcek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f19c04b into openshift:master May 13, 2021
@lukas-vlcek lukas-vlcek deleted the delete_logs branch June 10, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcantrill jcantrill Awaiting requested review from jcantrill

1 more reviewer

@ewolinetz ewolinetz ewolinetz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ewolinetz ewolinetz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukas-vlcek @ewolinetz @openshift-merge-robot