Skip to content

[release-5.1] LOG-1565: Use correct variable for nextIndex #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2021
Merged

[release-5.1] LOG-1565: Use correct variable for nextIndex #753

merged 1 commit into from
Jul 23, 2021

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #751

/assign sasagarw

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 13, 2021
Merged
@openshift-ci openshift-ci bot changed the title [release-5.1] LOG-1567: Use correct variable for nextIndex [release-5.0] LOG-1565: Use correct variable for nextIndex Jul 13, 2021
@sasagarw
Copy link
Contributor

sasagarw commented Jul 13, 2021 •
edited by openshift-ci bot
Loading

/retitle [release-5.1] LOG-1565: Use correct variable for nextIndex

@openshift-ci openshift-ci bot changed the title [release-5.0] LOG-1565: Use correct variable for nextIndex [release-5.1] LOG-1565: Use correct variable for nextIndex Jul 13, 2021
periklis
periklis approved these changes Jul 13, 2021
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@periklis
Copy link
Contributor

/approve

@sasagarw
Copy link
Contributor

@periklis Looks like you already approved the PR. We need to wait for 1 more approval from @igor-karpukhin

@periklis
Copy link
Contributor

@periklis Looks like you already approved the PR. We need to wait for 1 more approval from @igor-karpukhin

Nope. I can't approve on this branch yet. I added only my LGTM.

@sasagarw
Copy link
Contributor

@periklis can I get approved label now? I see that OWNER file updation is merged.

@periklis
Copy link
Contributor

/hold On merging as we are effectively in code-freeze for 5.1.0 right now.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2021
@periklis
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@sasagarw
Copy link
Contributor

@periklis Can we cancel the hold on this now and get it merged?

@periklis
Copy link
Contributor

@periklis Can we cancel the hold on this now and get it merged?

No the release pipeline needs to get bumped to 5.1.1 so that new images with new content get tagged as such.

@periklis
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2021
@periklis
Copy link
Contributor

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 0fcd298 into openshift:release-5.1 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igor-karpukhin igor-karpukhin Awaiting requested review from igor-karpukhin

@syedriko syedriko Awaiting requested review from syedriko

1 more reviewer

@periklis periklis periklis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@periklis periklis

@sasagarw sasagarw

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @sasagarw @periklis @openshift-merge-robot