-
Notifications
You must be signed in to change notification settings - Fork 90
Make the operator tolerate missing console CRDs in OCP 4.12+ #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the operator tolerate missing console CRDs in OCP 4.12+ #942
Conversation
|
Skipping CI for Draft Pull Request. |
|
/hold I'm trying to see if a solution that doesn't require access to api extensions would work |
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aminesnow, periklis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a5a39ef to
4562bfc
Compare
|
@aminesnow: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/cherry-pick release-5.5 |
|
@aminesnow: new pull request created: #943 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description
Starting in Openshift 4.12, the
Consolewill be an optional component. This PR makes sure the ES operator tolerates the missing console CRDs (mainlyConsoleLinkandConsoleExternalLogLink)/cc @periklis
/assign @xperimental
Links