ACM-25660: Add Konflux build configuration for backplane-2.11 #384
Conversation
rivkyrizel
commented
Nov 10, 2025
rivkyrizel
commented
- Add Tekton pipeline definitions for pull requests and pushes
- Add Dockerfile.konflux for Konflux builds
- Add rpms configuration files for dependency management
- Update builder image to golang v1.24
|
@rivkyrizel: This pull request references ACM-25660 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
rivkyrizel
force-pushed
the
ACM-25660
branch
from
87a873e to
249c3d7
Compare
carbonin
left a comment
carbonin
left a comment
There was a problem hiding this comment.
I think this is still missing some things.
Compare these files to the ones from the previous branches. I tagged a few, but I'm not sure I found all of them.
| description: Skip checks against built image | ||
| name: skip-checks | ||
| type: string | ||
| - default: "false" |
There was a problem hiding this comment.
This needs to be "true" I think
| description: Execute the build with network isolation | ||
| name: hermetic | ||
| type: string | ||
| - default: "" |
There was a problem hiding this comment.
I think we need something here for go and rpms. check the other branches for exactly what it needs to be.
| 1h, 2d, 3w for hours, days, and weeks, respectively. | ||
| name: image-expires-after | ||
| type: string | ||
| - default: "false" |
There was a problem hiding this comment.
Pretty sure we need this as well.
rivkyrizel
force-pushed
the
ACM-25660
branch
from
249c3d7 to
f1fb066
Compare
|
@rivkyrizel there are still a lot of differences in the tasks between the pull-request pipeline in your branch and the one in backplane-2.10. |
- Add Tekton pipeline definitions for pull requests and pushes - Add Dockerfile.konflux for Konflux builds - Add rpms configuration files for dependency management - Update builder image to golang v1.24
rivkyrizel
force-pushed
the
ACM-25660
branch
from
f1fb066 to
84bb5e7
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carbonin, rivkyrizel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 0d2316c
into
openshift:backplane-2.11
4 participants
