Skip to content

Bug 2037288: Eliminate unsafe default for ironic agent image #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

Bug 2037288: Eliminate unsafe default for ironic agent image #22

merged 1 commit into from
Jan 5, 2022

Conversation

@zaneb
Copy link
Member

@zaneb zaneb commented Dec 7, 2021

We never want to source this image from quay.io/dtantsur in the real
world, so require it to be specified explicitly.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from hardys and sadasu December 7, 2021 22:30
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2021
@zaneb
Copy link
Member Author

zaneb commented Dec 7, 2021

This is currently still useful for testing, but putting this PR here so we will not forget to eliminate it.
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 7, 2021
@zaneb
Eliminate unsafe default for ironic agent image
4c5adb7 
We never want to source this image from quay.io/dtantsur in the real
world, so require it to be specified explicitly.
@zaneb zaneb force-pushed the agent-image-required branch from f57e4e2 to 4c5adb7 Compare December 9, 2021 17:07
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2021
@zaneb
Copy link
Member Author

zaneb commented Jan 4, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 4, 2022
dtantsur
dtantsur reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@dtantsur dtantsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HEY, you're removing my backdoor!! :)

/lgtm

cmd/static-server/main_test.go
IronicBaseURL: "http://example.com",
DeployISO: "foo.iso",
IronicBaseURL: "http://example.com",
IronicAgentImage: "quay.io/tantsur/ironic-agent",
Copy link
Member

@dtantsur dtantsur Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing "d" before "tantsur" :)

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2022
@hardys
Copy link
Contributor

hardys commented Jan 5, 2022

/retitle Bug 2037288: Eliminate unsafe default for ironic agent image

Heh I just noticed this looking at the code and raised a bz, which I guess we need to land this now :)

@openshift-ci openshift-ci bot changed the title Eliminate unsafe default for ironic agent image Bug 2037288: Eliminate unsafe default for ironic agent image Jan 5, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@zaneb: This pull request references Bugzilla bug 2037288, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request.

In response to this:

Bug 2037288: Eliminate unsafe default for ironic agent image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@zaneb: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cde3c81 into openshift:main Jan 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2022

@zaneb: All pull requests linked via external trackers have merged:

Bugzilla bug 2037288 has been moved to the MODIFIED state.

In response to this:

Bug 2037288: Eliminate unsafe default for ironic agent image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtantsur dtantsur dtantsur left review comments

@hardys hardys Awaiting requested review from hardys

@sadasu sadasu Awaiting requested review from sadasu

Assignees

@dtantsur dtantsur

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zaneb @hardys @dtantsur @openshift-merge-robot