Skip to content

Conversation

@sadasu
Copy link
Contributor

@sadasu sadasu commented May 13, 2022

In addition to providing the desited hostname of the machine in the
/etc/NetworkManager/dispatcher.d path also provide it in
/sysroot/etc/NetworkManager/dispatcher.d

In addition to providing the desited hostname of the machine in the
/etc/NetworkManager/dispatcher.d path also provide it in
/sysroot/etc/NetworkManager/dispatcher.d
@openshift-ci openshift-ci bot requested review from hardys and zaneb May 13, 2022 14:21
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@zaneb
Copy link
Member

zaneb commented May 13, 2022

This is a plausible theory and the code looks good to me, let's see what happens.

@sadasu
Copy link
Contributor Author

sadasu commented May 13, 2022

/retest

@sadasu sadasu changed the title Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d also Bug 2041183: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d also May 13, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2022

@sadasu: This pull request references Bugzilla bug 2041183, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yporagpa@redhat.com), skipping review request.

In response to this:

Bug 2041183: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d also

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadasu
Copy link
Contributor Author

sadasu commented May 16, 2022

/retest

2 similar comments
@sadasu
Copy link
Contributor Author

sadasu commented Jun 2, 2022

/retest

@sadasu
Copy link
Contributor Author

sadasu commented Jul 12, 2022

/retest

@elfosardo
Copy link
Contributor

/lgtm

@elfosardo
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 42b4b1f and 8 for PR HEAD a828dca in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 42b4b1f and 7 for PR HEAD a828dca in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 42b4b1f and 6 for PR HEAD a828dca in total

@sadasu
Copy link
Contributor Author

sadasu commented Jul 25, 2022

/retest

1 similar comment
@elfosardo
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD 5e13211 and 5 for PR HEAD a828dca in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 1 against base HEAD 5e13211 and 4 for PR HEAD a828dca in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5e13211 and 3 for PR HEAD a828dca in total

@sadasu
Copy link
Contributor Author

sadasu commented Aug 9, 2022

/hold
Too many retests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2022
@sadasu
Copy link
Contributor Author

sadasu commented Sep 26, 2022

/retest

@sadasu
Copy link
Contributor Author

sadasu commented Oct 11, 2022

/retest-required

@openshift-bot
Copy link

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

@openshift-ci openshift-ci bot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Oct 28, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2022

@openshift-bot: This pull request references Bugzilla bug 2041183, which is invalid:

  • expected the bug to target the "4.13.0" release, but it targets "4.10.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@elfosardo
Copy link
Contributor

/retest

@dougsland
Copy link

@sadasu hey, I am back, just wondering if there is any patch pending to test this one.

@dougsland
Copy link

/retest

1 similar comment
@sadasu
Copy link
Contributor Author

sadasu commented Dec 6, 2022

/retest

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 7, 2023
@dtantsur
Copy link
Member

dtantsur commented Apr 3, 2023

/retitle OCPBUGS-9072: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d as well

@openshift-ci openshift-ci bot changed the title Bug 2041183: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d also OCPBUGS-9072: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d as well Apr 3, 2023
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 3, 2023
@openshift-ci-robot
Copy link

@sadasu: This pull request references Jira Issue OCPBUGS-9072, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (yporagpa@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

In addition to providing the desited hostname of the machine in the
/etc/NetworkManager/dispatcher.d path also provide it in
/sysroot/etc/NetworkManager/dispatcher.d

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 3, 2023
@dtantsur
Copy link
Member

dtantsur commented Apr 3, 2023

/retest
/remove-lifecycle stale

@openshift-ci openshift-ci bot removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2023

@sadasu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

OCPBUGS-9072: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d as well

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dtantsur
Copy link
Member

dtantsur commented Apr 3, 2023

I suspect /sysroot/etc/NetworkManager/dispatcher.d/ is not actually a thing. At least that's very far from how /sysroot looks on my testing system.

@dtantsur
Copy link
Member

dtantsur commented Apr 3, 2023

Experimenting with an agent-based approach: openshift/ironic-agent-image#73

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 3, 2023

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi a828dca link true /test e2e-metal-ipi
ci/prow/e2e-metal-ipi-sdn a828dca link true /test e2e-metal-ipi-sdn
ci/prow/e2e-metal-ipi-sdn-bm a828dca link true /test e2e-metal-ipi-sdn-bm
ci/prow/e2e-metal-ipi-serial-ipv4 a828dca link true /test e2e-metal-ipi-serial-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dtantsur
Copy link
Member

/close

This approach does not work. I'll close the PR because I cannot update it in the future. Thank you Sandhya for working on this bug!

@openshift-ci openshift-ci bot closed this Apr 12, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 12, 2023

@dtantsur: Closed this PR.

In response to this:

/close

This approach does not work. I'll close the PR because I cannot update it in the future. Thank you Sandhya for working on this bug!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@sadasu: This pull request references Jira Issue OCPBUGS-9072. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

In addition to providing the desited hostname of the machine in the
/etc/NetworkManager/dispatcher.d path also provide it in
/sysroot/etc/NetworkManager/dispatcher.d

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zaneb
Copy link
Member

zaneb commented Apr 13, 2023

I suspect /sysroot/etc/NetworkManager/dispatcher.d/ is not actually a thing. At least that's very far from how /sysroot looks on my testing system.

@dtantsur when Ignition runs, / is the mounted initramfs and /sysroot is the filesystem we are going to pivot into, i.e. what will become / once the system is booted. There's no way to see how it looks at Ignition time because you can't get into the system until after the pivot.
That's not to say this will work; it's entirely possible it doesn't for any number of reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants