-
Notifications
You must be signed in to change notification settings - Fork 20
OCPBUGS-9072: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d as well #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In addition to providing the desited hostname of the machine in the /etc/NetworkManager/dispatcher.d path also provide it in /sysroot/etc/NetworkManager/dispatcher.d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadasu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is a plausible theory and the code looks good to me, let's see what happens. |
|
/retest |
|
@sadasu: This pull request references Bugzilla bug 2041183, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yporagpa@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
/hold |
|
/retest |
|
/retest-required |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity. |
|
@openshift-bot: This pull request references Bugzilla bug 2041183, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@sadasu hey, I am back, just wondering if there is any patch pending to test this one. |
|
/retest |
1 similar comment
|
/retest |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
/retitle OCPBUGS-9072: Copy hostname into /sysroot/etc/NetworkManager/dispatcher.d as well |
|
@sadasu: This pull request references Jira Issue OCPBUGS-9072, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (yporagpa@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@sadasu: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I suspect |
|
Experimenting with an agent-based approach: openshift/ironic-agent-image#73 |
|
@sadasu: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close This approach does not work. I'll close the PR because I cannot update it in the future. Thank you Sandhya for working on this bug! |
|
@dtantsur: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sadasu: This pull request references Jira Issue OCPBUGS-9072. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dtantsur when Ignition runs, |
In addition to providing the desited hostname of the machine in the
/etc/NetworkManager/dispatcher.d path also provide it in
/sysroot/etc/NetworkManager/dispatcher.d