Skip to content

Conversation

@jankaluza
Copy link

@jankaluza jankaluza commented Aug 20, 2025

This commit switch from github.com/containers/storage to go.podman.io/storage.

It has been generated by:

$ vi go.mod to change the dependency
$ find . -type f -name '*.go' -exec sed -i -e 's,"github.com/containers/storage,"go.podman.io/storage,g' {} \;
$ goimports -v -w .
$ go mod tidy
$ go mod vendor

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 20, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

Hi @jankaluza. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…rs/storage.

Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
@jankaluza jankaluza changed the title Do not merge: Test build from monorepo Use go.podman.io/storage from monorepo instead of github.com/containers/storage. Aug 26, 2025
module github.com/openshift/imagebuilder

go 1.22.0
go 1.23.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nalind or @flouthoc any concerns with this Go bump?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openshift/builder repository is using "toolchain 1.23.1", and containers projects' main branches are on 1.23, so I think we're okay.

@TomSweeneyRedHat
Copy link
Contributor

LGTM
once the tests are hip, and if @nalind and @flouthoc don't have issues with the Go bump

@nalind
Copy link
Member

nalind commented Aug 26, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2025

@jankaluza: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@TomSweeneyRedHat
Copy link
Contributor

All happy Green Test Buttons

@nalind
Copy link
Member

nalind commented Aug 26, 2025

What's with the whitespace changes in evaluator.go?

@jankaluza
Copy link
Author

@nalind , it's like goimports -v -w . formats the file. I wanted to change it, but also vscode auto-formats this by default the very same way, so I thought it is actually the preferred way for go.

I understand this is not directly related to the code-change I'm doing here, so I'm OK to remove these white-space changes if you think so. Just tell me.

Copy link
Member

@nalind nalind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine.
/lgtm

@nalind
Copy link
Member

nalind commented Aug 28, 2025

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankaluza, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 95f7000 into openshift:master Aug 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants