-
Notifications
You must be signed in to change notification settings - Fork 73
Use go.podman.io/storage from monorepo instead of github.com/containers/storage. #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @jankaluza. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…rs/storage. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
| module github.com/openshift/imagebuilder | ||
|
|
||
| go 1.22.0 | ||
| go 1.23.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openshift/builder repository is using "toolchain 1.23.1", and containers projects' main branches are on 1.23, so I think we're okay.
|
/ok-to-test |
|
@jankaluza: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
All happy Green Test Buttons |
|
What's with the whitespace changes in |
|
@nalind , it's like I understand this is not directly related to the code-change I'm doing here, so I'm OK to remove these white-space changes if you think so. Just tell me. |
nalind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankaluza, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit switch from github.com/containers/storage to go.podman.io/storage.
It has been generated by: