Skip to content

OCPBUGS-66250: Replace terraform-provider-google with Openshift fork#10144

Merged
sdodson merged 1 commit intoopenshift:release-4.12from
sunku5494:OCPBUGS-66250
Dec 18, 2025
Merged

OCPBUGS-66250: Replace terraform-provider-google with Openshift fork#10144
sdodson merged 1 commit intoopenshift:release-4.12from
sunku5494:OCPBUGS-66250

Conversation

@sunku5494
Copy link
Contributor

/assign @sunku5494

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 2, 2025
@openshift-ci-robot
Copy link
Contributor

@sunku5494: This pull request references Jira Issue OCPBUGS-66250, which is invalid:

  • expected Jira Issue OCPBUGS-66250 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/assign @sunku5494

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign r4f4 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon
Copy link
Contributor

/retest-required

Copy link
Contributor

@barbacbd barbacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the 4.13 PR, The following issue is observed in the tests

error: unable to create a release: operator "cluster-cloud-controller-manager-operator" contained an invalid image-references file: no input image tag named "openstack-cloud-controller-manager"

@patrickdillon is this something new we are referencing or something that was removed?

@patrickdillon
Copy link
Contributor

/retest

2 similar comments
@tthvo
Copy link
Member

tthvo commented Dec 16, 2025

/retest

@sunku5494
Copy link
Contributor Author

/retest

@tthvo
Copy link
Member

tthvo commented Dec 16, 2025

/retest-required

ci/prow/e2e-gcp-ovn passed 🟢

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

@sunku5494: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack b68837a link false /test e2e-azurestack
ci/prow/okd-scos-e2e-gcp b68837a link false /test okd-scos-e2e-gcp
ci/prow/e2e-gcp-ovn-byo-vpc b68837a link false /test e2e-gcp-ovn-byo-vpc
ci/prow/e2e-azure-ovn-resourcegroup b68837a link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-aws-ovn-proxy b68837a link false /test e2e-aws-ovn-proxy
ci/prow/okd-scos-e2e-aws-upgrade b68837a link false /test okd-scos-e2e-aws-upgrade
ci/prow/okd-scos-e2e-aws-ovn b68837a link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade b68837a link false /test okd-scos-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Dec 17, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Jira Issue OCPBUGS-66250, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Dec 17, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

@sdodson: This pull request references Jira Issue OCPBUGS-66250, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-66232 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-66232 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from jianli-wei December 17, 2025 16:06
@sdodson
Copy link
Member

sdodson commented Dec 18, 2025

@tthvo mind reviewing, i'm hoping that once we get this in the 4.13 jobs which install 4.12 first will start passing again.

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/verified by e2e-gcp-ovn

The vendor shows the necessary changes. LGTM!

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/tide refresh

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/payload-job periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-rt-upgrade

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@tthvo: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.13-upgrade-from-stable-4.12-e2e-gcp-ovn-rt-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0d70e0e0-dbcf-11f0-8437-104db454027f-0

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/test ci/prow/e2e-gcp-ovn-byo-vpc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@tthvo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test aro-unit
/test e2e-agent-compact
/test e2e-aws-ovn
/test e2e-aws-ovn-upi
/test e2e-azure-ovn
/test e2e-azure-ovn-upi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-upi
/test gofmt
/test golint
/test govet
/test images
/test okd-scos-images
/test shellcheck
/test tf-lint
/test unit
/test verify-codegen
/test verify-vendor
/test yaml-lint

The following commands are available to trigger optional jobs:

/test e2e-agent-mce
/test e2e-alibaba
/test e2e-aws-ovn-disruptive
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-imdsv2
/test e2e-aws-ovn-proxy
/test e2e-aws-ovn-shared-vpc
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-upi-proxy
/test e2e-azure-ovn-resourcegroup
/test e2e-azure-ovn-shared-vpc
/test e2e-azurestack
/test e2e-azurestack-upi
/test e2e-crc
/test e2e-gcp-ovn-byo-vpc
/test e2e-gcp-upgrade
/test e2e-gcp-upi-xpn
/test e2e-ibmcloud-ovn
/test e2e-libvirt
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-virtualmedia
/test e2e-metal-ipi-sdn
/test e2e-metal-ipi-sdn-swapped-hosts
/test e2e-metal-single-node-live-iso
/test e2e-nutanix-ovn
/test e2e-nutanix-sdn
/test e2e-ovirt-sdn
/test e2e-vsphere-zones
/test okd-scos-e2e-aws-ovn
/test okd-scos-e2e-aws-upgrade
/test okd-scos-e2e-gcp
/test okd-scos-e2e-gcp-ovn-upgrade
/test okd-scos-unit
/test okd-scos-verify-codegen
/test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-installer-release-4.12-aro-unit
pull-ci-openshift-installer-release-4.12-e2e-agent-compact
pull-ci-openshift-installer-release-4.12-e2e-aws-ovn
pull-ci-openshift-installer-release-4.12-e2e-aws-ovn-fips
pull-ci-openshift-installer-release-4.12-e2e-aws-ovn-imdsv2
pull-ci-openshift-installer-release-4.12-e2e-aws-ovn-proxy
pull-ci-openshift-installer-release-4.12-e2e-aws-ovn-shared-vpc
pull-ci-openshift-installer-release-4.12-e2e-aws-ovn-single-node
pull-ci-openshift-installer-release-4.12-e2e-azure-ovn
pull-ci-openshift-installer-release-4.12-e2e-azure-ovn-resourcegroup
pull-ci-openshift-installer-release-4.12-e2e-azure-ovn-shared-vpc
pull-ci-openshift-installer-release-4.12-e2e-azurestack
pull-ci-openshift-installer-release-4.12-e2e-gcp-ovn
pull-ci-openshift-installer-release-4.12-e2e-gcp-ovn-byo-vpc
pull-ci-openshift-installer-release-4.12-gofmt
pull-ci-openshift-installer-release-4.12-golint
pull-ci-openshift-installer-release-4.12-govet
pull-ci-openshift-installer-release-4.12-images
pull-ci-openshift-installer-release-4.12-okd-scos-e2e-aws-ovn
pull-ci-openshift-installer-release-4.12-okd-scos-e2e-aws-upgrade
pull-ci-openshift-installer-release-4.12-okd-scos-e2e-gcp
pull-ci-openshift-installer-release-4.12-okd-scos-e2e-gcp-ovn-upgrade
pull-ci-openshift-installer-release-4.12-okd-scos-images
pull-ci-openshift-installer-release-4.12-okd-scos-unit
pull-ci-openshift-installer-release-4.12-okd-scos-verify-codegen
pull-ci-openshift-installer-release-4.12-shellcheck
pull-ci-openshift-installer-release-4.12-tf-fmt
pull-ci-openshift-installer-release-4.12-tf-lint
pull-ci-openshift-installer-release-4.12-unit
pull-ci-openshift-installer-release-4.12-verify-codegen
pull-ci-openshift-installer-release-4.12-verify-vendor
pull-ci-openshift-installer-release-4.12-yaml-lint
Details

In response to this:

/test ci/prow/e2e-gcp-ovn-byo-vpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

/test e2e-gcp-ovn-byo-vpc

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

@tthvo mind reviewing, i'm hoping that once we get this in the 4.13 jobs which install 4.12 first will start passing again.

Hey @sdodson, I am guessing you meant, for example, this job: #10144 (comment) so I launched one to double check 👀

I applied the lgtm (and later verified). Maybe you can help with the rest of the labels?

@tthvo
Copy link
Member

tthvo commented Dec 18, 2025

😓 The payload testing failed with the same error... Maybe, the change didn't apply because the job is meant to upgrade from a released 4.12.z?

I think the presubmit passed so I am OK if we add verified here. What are your thoughts?

@sdodson
Copy link
Member

sdodson commented Dec 18, 2025

/label approved backport-risk-assessed
/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 18, 2025
@openshift-ci-robot
Copy link
Contributor

@sdodson: This PR has been marked as verified by CI.

Details

In response to this:

/label approved backport-risk-assessed
/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Dec 18, 2025

/label approved backport-risk-assessed

@sdodson sdodson merged commit cd642be into openshift:release-4.12 Dec 18, 2025
24 of 33 checks passed
@openshift-ci-robot
Copy link
Contributor

@sunku5494: Jira Issue Verification Checks: Jira Issue OCPBUGS-66250
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-66250 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

/assign @sunku5494

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.12.0-0.nightly-2025-12-18-192430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants