OCPBUGS-67314: AGENT-1357 remove AgentWorkflowTypeInstallInteractiveDisconnected workflow by openshift-cherrypick-robot · Pull Request #10161 · openshift/installer

openshift-cherrypick-robot · 2025-12-12T15:44:45Z

This is an automated cherry-pick of #10020

/assign pawanpinjarkar

…rkflow Remove the interactive disconnected workflow type. The appliance embeds registries.conf and CA certificates directly in the system ignition for bootstrap, eliminating the need for a separate workflow type. Key changes: Command-line interface: - Remove --interactive flag from unconfigured-ignition command - Remove ContextWrapper and workflow context management Workflow handling: - Simplify to always use AgentWorkflowTypeInstall for unconfigured ignition - Remove AgentWorkflowTypeInstallInteractiveDisconnected constant - Remove workflow type switching logic in UnconfiguredIgnition - Remove workflow dependency from UnconfiguredIgnition asset Mirror configuration: - Remove RegistriesConf and CaBundle dependencies from UnconfiguredIgnition - Remove addMirrorData() call (appliance provides this) - Remove early returns for interactive workflow in mirror assets Testing: - Remove interactive-disconnected-workflow test case - Remove with-mirror-configs test case from unconfigured ignition tests - Update default dependencies in test helpers Rationale: The OVE appliance provides a more robust solution for disconnected installations by embedding all necessary configuration (registries, certificates, UI) directly in the appliance image. This approach: - Eliminates workflow type complexity - Decouples installer and appliance repositories - Simplifies the codebase by removing conditional logic - Aligns with the architecture where MCO manages post-bootstrap config After first node reboot, the Machine Config Operator manages registry configuration and trust bundles via IDMS/IDMT resources. Commit message text generated by: Claude AI <noreply@anthropic.com>

openshift-ci-robot · 2025-12-12T15:44:48Z

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: AGENT-1357

Details

In response to this:

This is an automated cherry-pick of #10020

/assign pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pawanpinjarkar · 2025-12-12T16:26:27Z

/approve

pawanpinjarkar · 2025-12-12T16:26:44Z

/label backport-risk-assessed

openshift-ci · 2025-12-12T16:28:18Z

@pawanpinjarkar: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-12-12T16:28:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [pawanpinjarkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pawanpinjarkar · 2025-12-12T18:35:23Z

/test e2e-agent-compact-ipv4-iso-no-registry

pawanpinjarkar · 2025-12-12T18:58:05Z

/retitle "OCPBUGS-67314:[release-4.21] AGENT-1357: remove AgentWorkflowTypeInstallInteractiveDisconnected workflow"

openshift-ci-robot · 2025-12-12T18:58:14Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-67314, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-67314 to depend on a bug targeting a version in 4.22.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #10020

/assign pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pawanpinjarkar · 2025-12-12T19:00:08Z

/jira refresh

openshift-ci-robot · 2025-12-12T19:00:12Z

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-67314, which is invalid:

expected Jira Issue OCPBUGS-67314 to depend on a bug targeting a version in 4.22.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pawanpinjarkar · 2025-12-12T19:05:11Z

/jira refresh

openshift-ci-robot · 2025-12-12T19:05:16Z

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-67314, which is invalid:

expected dependent Jira Issue OCPBUGS-67315 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pawanpinjarkar · 2025-12-12T19:06:35Z

/retitle OCPBUGS-67314: AGENT-1357 remove AgentWorkflowTypeInstallInteractiveDisconnected workflow

pawanpinjarkar · 2025-12-12T19:06:45Z

/jira refresh

openshift-ci-robot · 2025-12-12T19:06:54Z

@pawanpinjarkar: This pull request references Jira Issue OCPBUGS-67314, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-67315 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-67315 targets the "4.22.0" version, which is one of the valid target versions: 4.22.0
bug has dependents

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pawanpinjarkar · 2025-12-12T21:06:44Z

/test e2e-agent-compact-ipv4-iso-no-registry

openshift-ci · 2025-12-12T21:48:39Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-compact-ipv4-none-platform	`604a691`	link	false	`/test e2e-agent-compact-ipv4-none-platform`
ci/prow/e2e-agent-5control-ipv4	`604a691`	link	false	`/test e2e-agent-5control-ipv4`
ci/prow/e2e-agent-sno-ipv4-pxe	`604a691`	link	false	`/test e2e-agent-sno-ipv4-pxe`
ci/prow/e2e-agent-two-node-fencing-ipv4	`604a691`	link	false	`/test e2e-agent-two-node-fencing-ipv4`
ci/prow/e2e-agent-sno-ipv6	`604a691`	link	false	`/test e2e-agent-sno-ipv6`
ci/prow/e2e-agent-ha-dualstack	`604a691`	link	false	`/test e2e-agent-ha-dualstack`
ci/prow/e2e-agent-compact-ipv6-minimaliso	`604a691`	link	false	`/test e2e-agent-compact-ipv6-minimaliso`
ci/prow/e2e-agent-4control-ipv4	`604a691`	link	false	`/test e2e-agent-4control-ipv4`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pawanpinjarkar · 2025-12-15T00:57:59Z

/retest-required
/test e2e-agent-compact-ipv4-iso-no-registry

pawanpinjarkar · 2025-12-15T13:58:08Z

/lgtm

pawanpinjarkar · 2025-12-15T13:58:23Z

/verified by e2e-agent-compact-ipv4-iso-no-registry

openshift-ci-robot · 2025-12-15T13:58:35Z

@pawanpinjarkar: This PR has been marked as verified by [e2e-agent-compact-ipv4-iso-no-registry](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/10161/pull-ci-openshift-installer-release-4.21-e2e-agent-compact-ipv4-iso-no-registry/2000369727095967744).

Details

In response to this:

/verified by e2e-agent-compact-ipv4-iso-no-registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pawanpinjarkar · 2025-12-15T13:58:38Z

/backport-risk-assessed

bfournie · 2025-12-15T14:07:26Z

/label backport-risk-assessed

pawanpinjarkar · 2025-12-15T19:02:04Z

@zaneb Can you please add backport-risk-assessed label

zaneb · 2025-12-15T22:28:36Z

/label backport-risk-assessed

openshift-ci-robot · 2025-12-16T01:49:21Z

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-67314
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-67314 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #10020

/assign pawanpinjarkar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2025-12-18T09:31:51Z

Fix included in accepted release 4.21.0-0.nightly-2025-12-18-020818

openshift-cherrypick-robot assigned pawanpinjarkar Dec 12, 2025

openshift-cherrypick-robot mentioned this pull request Dec 12, 2025

AGENT-1357: remove AgentWorkflowTypeInstallInteractiveDisconnected workflow #10020

Merged

5 tasks

openshift-ci bot requested review from andfasano and bfournie December 12, 2025 15:47

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025

openshift-ci bot changed the title ~~[release-4.21] AGENT-1357: remove AgentWorkflowTypeInstallInteractiveDisconnected workflow~~ "OCPBUGS-67314:[release-4.21] AGENT-1357: remove AgentWorkflowTypeInstallInteractiveDisconnected workflow" Dec 12, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2025

openshift-ci bot changed the title ~~"OCPBUGS-67314:[release-4.21] AGENT-1357: remove AgentWorkflowTypeInstallInteractiveDisconnected workflow"~~ OCPBUGS-67314: AGENT-1357 remove AgentWorkflowTypeInstallInteractiveDisconnected workflow Dec 12, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2025

openshift-ci bot requested a review from mhanss December 12, 2025 19:06

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 15, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2025

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 15, 2025

openshift-merge-bot bot merged commit a4e1c18 into openshift:release-4.21 Dec 16, 2025
18 of 26 checks passed

Conversation

openshift-cherrypick-robot commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pawanpinjarkar commented Dec 12, 2025

Uh oh!

pawanpinjarkar commented Dec 12, 2025

Uh oh!

openshift-ci bot commented Dec 12, 2025

Uh oh!

openshift-ci bot commented Dec 12, 2025

Uh oh!

pawanpinjarkar commented Dec 12, 2025

Uh oh!

pawanpinjarkar commented Dec 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

pawanpinjarkar commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

pawanpinjarkar commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

pawanpinjarkar commented Dec 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pawanpinjarkar commented Dec 12, 2025

Uh oh!

openshift-ci-robot commented Dec 12, 2025

Uh oh!

pawanpinjarkar commented Dec 12, 2025

Uh oh!

openshift-ci bot commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pawanpinjarkar commented Dec 15, 2025

Uh oh!

pawanpinjarkar commented Dec 15, 2025

Uh oh!

pawanpinjarkar commented Dec 15, 2025

Uh oh!

openshift-ci-robot commented Dec 15, 2025

Uh oh!

pawanpinjarkar commented Dec 15, 2025

Uh oh!

bfournie commented Dec 15, 2025

Uh oh!

pawanpinjarkar commented Dec 15, 2025

Uh oh!

zaneb commented Dec 15, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Dec 16, 2025

Uh oh!

openshift-merge-robot commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Dec 12, 2025 •

edited by openshift-ci bot

Loading

pawanpinjarkar commented Dec 12, 2025 •

edited by openshift-ci bot

Loading

pawanpinjarkar commented Dec 12, 2025 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Dec 12, 2025 •

edited

Loading