Skip to content

Revert "openstack: Del DNS from service VM update docs"#1094

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tomassedovic:reverte-openstack-dns-removal
Jan 23, 2019
Merged

Revert "openstack: Del DNS from service VM update docs"#1094
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tomassedovic:reverte-openstack-dns-removal

Conversation

@tomassedovic
Copy link
Contributor

This reverts commit ae54392.

The proposed solution (including the exact same CoreDNS configuration)
does not work for several of our developers deployments causing a
regression (i.e. we're not able to get the etcd cluster started).

It appears that the DNS requests are getting the CNAME values for the
etcd records, but they never resolve to an IP address.

We've not figured out why that is yet, so reverting this change lets us
unblock the OpenStack deployments.

This reverts commit ae54392.

The proposed solution (including the exact same CoreDNS configuration)
does not work for several of our developers deployments causing a
regression (i.e. we're not able to get the etcd cluster started).

It appears that the DNS requests are getting the CNAME values for the
etcd records, but they never resolve to an IP address.

We've not figured out why that is yet, so reverting this change lets us
unblock the OpenStack deployments.
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 17, 2019
@tomassedovic
Copy link
Contributor Author

/hold

I'm not sure if this is clear for merging during the freeze (it does fix an issue preventing openstack deployments).

I'd also like to hear what @yboaron and @russellb (who wrote and merged the patch) think.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2019
@yboaron
Copy link
Contributor

yboaron commented Jan 17, 2019

I think we should go with this revert to allow deployments.

As next step, we should think how to flip the /etc/resolv.conf and in parallel try to figure out the cause for the different behavior.

@flaper87
Copy link
Contributor

I'm ok with this.

I'd like to get green light from @wking or someone from the openshift team, tho.

@tomassedovic
Copy link
Contributor Author

@wking or @crawford you okay merging this or should we wait?

It fixes an OpenStack deployment issue. I got the go-ahead from @russellb in private, too. The /hold is just to prevent the merge if this isn't the time.

@flaper87
Copy link
Contributor

/test e2e-aws

@russellb
Copy link
Contributor

russellb commented Jan 17, 2019 via email

@crawford
Copy link
Contributor

Once I see the written approval, I'll go ahead and merge this.

@flaper87
Copy link
Contributor

/test e2e-aws

@russellb
Copy link
Contributor

russellb commented Jan 18, 2019

Talked to @eparis , who said: "No need to ask for pemrission to fix bugs. Dear god, fix'em"

@crawford so should be good to go, then

@flaper87
Copy link
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2019
@flaper87
Copy link
Contributor

moving forward with this as it's been approved already: 👍

/lgtm

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@flaper87
Copy link
Contributor

moving forward with this as it's been approved already: 👍

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [flaper87,tomassedovic]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flaper87
Copy link
Contributor

/test e2e-aws

1 similar comment
@flaper87
Copy link
Contributor

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4b98666 into openshift:master Jan 23, 2019
@tomassedovic tomassedovic deleted the reverte-openstack-dns-removal branch January 23, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants