pkg/destroy/aws: Destroy all instances not terminated#1403
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Mar 12, 2019
Merged
pkg/destroy/aws: Destroy all instances not terminated#1403openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
Today the code only deletes running and pending instances. Not stopped, stopping, or shutting down. Those still cause dependency problem and should be cleaned up just like termineted. Instead of writing out the full list (and having to keep it up to date) instead I just skip termineted instances in code instead of tryin to filter during the API call.
openshift-ci-robot
added
the
size/S
staebler
reviewed
Mar 12, 2019
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, eparis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the code only deletes running and pending instances. Not stopped,
stopping, or shutting down. Those still cause dependency problem and
should be cleaned up just like termineted. Instead of writing out
the full list (and having to keep it up to date) instead I just skip
termineted instances in code instead of tryin to filter during the API
call.