tests/smoke/BUILD.bazel: Drop the 'smoke' target#143
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Aug 24, 2018
Merged
tests/smoke/BUILD.bazel: Drop the 'smoke' target#143openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
approved
Merged
wking
force-pushed
the
drop-smoke-target
branch
from
95cc31a to
17f5589
Compare
Member
Author
|
Rebased around #88 with 95cc31a -> 17f5589. |
Generated with: $ bazel run //:gazelle Using: $ bazel version Build label: 0.15.2- (@Non-Git) Build target: bazel-out/k8-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Tue Jul 17 13:32:28 2018 (1531834348) Build timestamp: 1531834348 Build timestamp as int: 1531834348
The 'smoke' target is a lot like the Gazelle-maintained go_default_test target, except that it's not automatically maintained. Make maintenance easier by pointing the smoke_tests alias straight at the automatically-maintained target. Generated with: $ rm smoke/tests/BUILD.bazel $ bazel run //:gazelle $ emacs smoke/tests/BUILD.bazel # add visibility Adding the visibility property avoids: $ bazel run smoke_tests ERROR: /home/trking/.local/lib/go/src/github.com/openshift/installer/BUILD.bazel:45:1: target '//tests/smoke:go_default_test' is not visible from target '//:smoke_tests'. Check the visibility declaration of the former target if you think the dependency is legitimate ERROR: Analysis of target '//:smoke_tests' failed; build aborted: Analysis of target '//:smoke_tests' failed; build aborted INFO: Elapsed time: 0.124s INFO: 0 processes. FAILED: Build did NOT complete successfully (1 packages loaded) FAILED: Build did NOT complete successfully (1 packages loaded) Running the smoke tests is also fairly orthogonal to building tarballs, so I've removed the smoke-test docs from Documentation/dev/build.md. The last test_vars consumer was removed in 7296010 (frontend: Remove frontend code and backend API code, 2018-03-06, coreos/tectonic-installer#3067), so I don't think its removal will be a problem. And because smoke.sh was removed in 1dea5c8 (tests: Remove unused smoke.sh + tfvars file, 2017-10-04, coreos/tectonic-installer#2036), I've just removed the whole tests/smoke/aws tree. And without that tree to explain, I've dropped the associated section from the smoke README as well.
wking
force-pushed
the
drop-smoke-target
branch
from
17f5589 to
71c27f6
Compare
Member
Author
Member
Author
|
All green here. Anyone free to take a look? @yifan-gu, @abhinavdahiya? |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
smoketarget was a lot like the Gazelle-maintainedgo_default_testtarget, except that it's not automatically maintained. Make maintenance easier by pointing thesmoke_testsalias straight at the automatically-maintained target. Generated with:Adding the visibility property avoids:
Running the smoke tests is also fairly orthogonal to building tarballs, so I've removed the smoke-test docs from
Documentation/dev/build.md.The last
test_varsconsumer was removed in 7296010 (coreos/tectonic-installer#3067), so I don't think its removal will be a problem. And becausesmoke.shwas removed in 1dea5c8 (coreos/tectonic-installer#2036), I've just removed the wholetests/smoke/awstree. And without that tree to explain, I've dropped the associated section from the smokeREADMEas well.This PR has two commits:
//:gazellerun, so you can see what it wants to change vs. the current master.smoke-dropping commit, so you can see what is being changed because of that.Spun off from #94 to get smaller, more-easily-reviewed chunks.