Skip to content

Add internal load balancer to GCP.#2448

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
patrickdillon:gcp-int-lb-cors-1235
Oct 3, 2019
Merged

Add internal load balancer to GCP.#2448
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
patrickdillon:gcp-int-lb-cors-1235

Conversation

@patrickdillon
Copy link
Contributor

JIRA: CORS-1235
Adds an internalTCP load balancer with instance groups containing the masters and bootstrap node(which has been removed from the external LB target pool). Points internal DNS to use this load balancer. Due to the restriction in the internal load balancer we can only perform one health check, so no health check is being performed against the mcs. We are assuming that if the api is alive and ready, so is mcs.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2019
@abhinavdahiya
Copy link
Contributor

/test e2e-gcp

@patrickdillon
Copy link
Contributor Author

/retest

@abhinavdahiya
Copy link
Contributor

https://github.com/openshift/installer/blob/39c63115aaf52181323d8b76807c3469465969cc/pkg/asset/machines/gcp/machines.go#L112

The master machines have reference to a dropped resource, which is making it fail when updating status of the machine.

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/2448/pull-ci-openshift-installer-master-e2e-gcp/85/artifacts/e2e-gcp/must-gather/registry-svc-ci-openshift-org-ci-op-v42w6l40-stable-sha256-8f5a70fa17fe774580a1431f3e987d8bdad27f3cfe322b5a590548926095a2ab/namespaces/openshift-machine-api/pods/machine-api-controllers-7c7f6c6568-d55gr/machine-controller/machine-controller/logs/current.log
2019-10-02T23:35:41.198445043Z E1002 23:35:41.195866 1 controller.go:246] Error updating machine "openshift-machine-api/ci-op--tv7q9-m-2": unable to get targetpool: googleapi: Error 404: The resource 'projects/openshift-gce-devel-ci/regions/us-east1/targetPools/ci-op--tv7q9-ign' was not found, notFound

Adds an internalTCP load balancer with instance groups containing the masters and bootstrap node(which has been removed from the external LB target pool).  Points internal DNS to use this load balancer. Due to the restriction in the internal load balancer we can only perform one health check, so no health check is being performed against the mcs. We are assuming that if the api is alive and ready, so is mcs.
The move to internal load balancers means we replace the ign target pool with an instance group. This commit removes the ignition target pool from the machine provider spec.
@abhinavdahiya
Copy link
Contributor

/test e2e-gcp

@abhinavdahiya
Copy link
Contributor

/approve

/cc @jstuever

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2019

@patrickdillon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack f869204 link /test e2e-openstack

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 31d81f2 into openshift:master Oct 3, 2019
@patrickdillon patrickdillon deleted the gcp-int-lb-cors-1235 branch October 24, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants