Skip to content

Add Kuryr UPI Documentation#2575

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
MaysaMacedo:kuryr-upi-install
Oct 31, 2019
Merged

Add Kuryr UPI Documentation#2575
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
MaysaMacedo:kuryr-upi-install

Conversation

@MaysaMacedo
Copy link
Contributor

This doc contains the steps needed to use Kuryr as the SDN
when deploying OpenShift on OpenStack and using a User Provided
Infrastructure.
This commit lists all the necessary steps manually, using the
openstack command to create and delete the resources.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2019
@MaysaMacedo
Copy link
Contributor Author

/label platform/openstack

@openshift-ci-robot openshift-ci-robot added platform/openstack size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2019
@MaysaMacedo
Copy link
Contributor Author

TODOs:

  • Validate steps
  • Consider modifying the resources creation to use tag
  • Delete the resources created by Kuryr

@luis5tb
Copy link
Contributor

luis5tb commented Oct 28, 2019

TODOs:

  • Validate steps
  • Consider modifying the resources creation to use tag
  • Delete the resources created by Kuryr

Note you also need to add information about the trunk creation for the worker nodes

@MaysaMacedo MaysaMacedo force-pushed the kuryr-upi-install branch 2 times, most recently from e9070a3 to 9f4e236 Compare October 30, 2019 11:09
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2019
@MaysaMacedo MaysaMacedo changed the title WIP: Add Kuryr UPI Documentation Add Kuryr UPI Documentation Oct 30, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2019
@MaysaMacedo
Copy link
Contributor Author

/assign @mandre

@dulek
Copy link
Contributor

dulek commented Oct 30, 2019

/lgtm

Seems okay to me. I don't like getting LB's one-by-one, but I see python-openstackclient has no support for listing LBs by tag, so I understand we're forced to do it like that.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@MaysaMacedo
Copy link
Contributor Author

/lgtm

Seems okay to me. I don't like getting LB's one-by-one, but I see python-openstackclient has no support for listing LBs by tag, so I understand we're forced to do it like that.

Yes. Tag is not supported on OSP 13, so we're tagging the resources on the description field. This is a safe way to delete them.

Copy link
Contributor

@tomassedovic tomassedovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of comments.

Regarding the subnet -> nodes rename, I'm not against it, but there's a few more place where we're using the old name. Can you please fix them all?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
This doc contains the steps needed to use Kuryr as the SDN
when deploying OpenShift on OpenStack and using a User Provided
Infrastructure.
This commit lists all the necessary steps manually, using the
`openstack` command to create and delete the resources.
@tomassedovic
Copy link
Contributor

/lgtm
/approve

Looking good, thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, MaysaMacedo, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@MaysaMacedo
Copy link
Contributor Author

/test e2e-aws-scaleup-rhel7

@openshift-merge-robot openshift-merge-robot merged commit 75ed3ec into openshift:master Oct 31, 2019
@MaysaMacedo MaysaMacedo deleted the kuryr-upi-install branch October 31, 2019 15:12
@openshift-ci-robot
Copy link
Contributor

@MaysaMacedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 bb48777 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/openstack size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants