README: Add console and cleanup information#402
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Oct 4, 2018
Merged
Conversation
openshift-ci-robot
added
size/M
docs/dev/libvirt-howto.md
Outdated
Contributor
There was a problem hiding this comment.
openshift usually recommends oc
Member
Author
There was a problem hiding this comment.
openshift usually recommends
oc
Orthogonal change to existing code ;). File a follow-up PR?
This restores the console docs which we'd removed from the README in feb41e9 (docs: rework documentation, 2018-09-24, openshift#328). And it moves the kubeconfig location information over from the libvirt-specific docs. Launching the cluster is nice, but these other operations are important too ;). Putting them in the README makes increases their visibility. It also lets us drom them from the libvirt-specific docs, now that the libvirt docs link to the README quick-start for these generic operations.
wking
force-pushed
the
readme-console-kubeconfig-and-cleanup
branch
from
219c70f to
f9f5e8d
Compare
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
CI failed with: /retest |
Member
Author
|
e2e: |
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Member
Author
|
e2e: Network hiccup? /retest |
This was referenced Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores the console docs which we'd removed from the README in feb41e9 (#328). And it moves the kubeconfig location information over from the libvirt-specific docs. Launching the cluster is nice, but these other operations are important too ;). Putting them in the README makes increases their visibility. It also lets us drom them from the libvirt-specific docs, now that the libvirt docs link to the README quick-start for these generic operations.