Bug 1786314: Bump dependencies#4561

Merged

openshift-merge-robot merged 1 commit intoopenshift:masterfrom

shiftstack:bz-1786314

Feb 17, 2021

Member

pierreprinetti commented Jan 18, 2021

github.com/gophercloud/gophercloud
github.com/gophercloud/utils
github.com/terraform-provider-openstack/terraform-provider-openstack

and dependant packages.

/label platform/openstack

openshift-ci-robot added do-not-merge/work-in-progress platform/openstack bugzilla/severity-low labels

Contributor

openshift-ci-robot commented Jan 18, 2021

@pierreprinetti: This pull request references Bugzilla bug 1786314, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

Bug 1786314: Bump dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/valid-bug label

Contributor

openshift-ci-robot commented Jan 18, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot requested review from Fedosin and jhixson74

January 18, 2021 11:52

pierreprinetti force-pushed the bz-1786314 branch from 92a5f9e to df44e24 Compare

January 19, 2021 19:36

pierreprinetti marked this pull request as ready for review

January 19, 2021 19:36

openshift-ci-robot removed the do-not-merge/work-in-progress label

pierreprinetti force-pushed the bz-1786314 branch 2 times, most recently from ecd263f to e30748c Compare

January 20, 2021 07:59

Fedosin reviewed

View reviewed changes

Contributor

Fedosin left a comment

/test e2e-gcp
/test e2e-azure

mandre reviewed

View reviewed changes

pkg/destroy/openstack/openstack.go Outdated Show resolved Hide resolved

pierreprinetti force-pushed the bz-1786314 branch from e30748c to 6bf0ce2 Compare

January 20, 2021 10:58

mandre reviewed

View reviewed changes

Member

mandre left a comment

/lgtm

openshift-ci-robot assigned mandre

openshift-ci-robot added the lgtm label

Member Author

pierreprinetti commented Jan 20, 2021

/assign @crawford

just as the bot suggests.

openshift-ci-robot assigned crawford

Member Author

pierreprinetti commented Jan 20, 2021

/test e2e-gcp
/test e2e-azure

Fedosin approved these changes

View reviewed changes

Contributor

Fedosin left a comment

/lgtm

openshift-ci-robot assigned Fedosin

Fedosin mentioned this pull request

Bump golang version for the installer to 1.15 openshift/release#15083

Closed

Contributor

Fedosin commented Jan 20, 2021

/hold

bumping golang to 1.15 breaks the installer: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/15083/rehearse-15083-pull-ci-openshift-installer-master-unit/1351880899611856896

openshift-ci-robot added the do-not-merge/hold label

pierreprinetti force-pushed the bz-1786314 branch from 6bf0ce2 to 799631e Compare

January 20, 2021 13:33

openshift-ci-robot removed the lgtm label

Member Author

pierreprinetti commented Jan 20, 2021

Removed the 1.15 bump. Thanks @Fedosin
/hold cancel

openshift-ci-robot added the lgtm label

Contributor

openshift-bot commented Feb 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Member Author

pierreprinetti commented Feb 15, 2021

/retest

Contributor

openshift-bot commented Feb 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments

Contributor

openshift-bot commented Feb 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Feb 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Feb 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Feb 15, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Feb 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Feb 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Feb 16, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

staebler commented Feb 16, 2021

/hold

This looks like a legitimate failure caused by these changes.

level=fatal msg=failed to fetch Master Machines: failed to load asset "Install Config": failed to create a network client: unable to load secure.yaml: no secure.yml file found

openshift-ci-robot added the do-not-merge/hold label

Member

EmilienM commented Feb 16, 2021 •

edited

Loading

I think we hit:

https://github.com/gophercloud/utils/blob/f6de111f2eaedc778f842096b07cbc319a7b3cdd/openstack/clientconfig/utils.go#L137-L170

func FindAndReadYAML(yamlFile string) (string, []byte, error) {
(...)
	return "", nil, fmt.Errorf("no %s file found: %w", yamlFile, os.ErrNotExist)
}

so maybe we need to create that file in our CI? Although it sounds backward incompatible change for our users who might not have secure.yaml.


          Upgrade OpenStack dependencies

567f660

* github.com/gophercloud/gophercloud
* github.com/gophercloud/utils
* github.com/terraform-provider-openstack/terraform-provider-openstack

Also adjust a call to servergroup.List to comply with the new function
signature[1].

[1]: gophercloud/gophercloud#2070

Signed-off-by: Emilien Macchi <emilien@redhat.com>

EmilienM force-pushed the bz-1786314 branch from 65659f1 to 567f660 Compare

February 16, 2021 16:48

openshift-ci-robot removed the lgtm label

Member

EmilienM commented Feb 16, 2021

/test e2e-openstack

Member

EmilienM commented Feb 16, 2021

/retest

mandre reviewed

View reviewed changes

Member

mandre left a comment

/lgtm

openshift-ci-robot added the lgtm label

Member

EmilienM commented Feb 16, 2021

/test e2e-aws-workers-rhel7

Member

EmilienM commented Feb 16, 2021

/retest

Member

EmilienM commented Feb 17, 2021

@staebler finally passing CI, any change to approve it please?

Thanks

Contributor

staebler commented Feb 17, 2021

@staebler finally passing CI, any change to approve it please?

Thanks

This has already been approved. I didn't mean to delay this PR with the hold: I only wanted to keep the tests from retrying.

/hold cancel

openshift-ci-robot removed the do-not-merge/hold label

openshift-merge-robot merged commit 0bc7d5b into openshift:master

Contributor

openshift-ci-robot commented Feb 17, 2021

@pierreprinetti: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/installer#4647 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1786314 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 1786314: Bump dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot mentioned this pull request

Bug 1786314: openstack: cacert does not require system trust #4647

Merged

pierreprinetti deleted the bz-1786314 branch

February 17, 2021 08:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jhixson74 Awaiting requested review from jhixson74

staebler Awaiting requested review from staebler

2 more reviewers

mandre mandre left review comments

Fedosin Fedosin approved these changes

Labels

approved bugzilla/severity-low bugzilla/valid-bug lgtm platform/openstack