Bug 1921627: Shorten instance group suffix to ig#4828
Conversation
GCP has a size restriction of 63 for the instance group name which is mostly taken up by the suffix -instance-group that is being added to make sure the resources have unique name. Reducing the size of the suffix from -instance-group to -ig would help in restricting the size of the name and would also help in keeping the names unique.
openshift-ci-robot
added
the
bugzilla/severity-low
|
@rna-afk: This pull request references Bugzilla bug 1921627, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/bugzilla refresh |
|
@rna-afk: This pull request references Bugzilla bug 1921627, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (yanyang@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/test e2e-gcp |
|
You will want a corresponding PR for CI. The CI script follows the UPI docs and, I believe, utilizes these Python scripts. So this is probably actually breaking CI--hard to tell as it looks like the job is broken. |
@e-tienne is looking at fixing the e2e-gcp-upi tests. So let's wait for some progress on that effort, since the changes in this PR are not strictly blocking anything. |
openshift-ci-robot
added
the
do-not-merge/hold
|
The e2e-gcp-upi tests should succeed now. |
|
/test e2e-gcp-upi |
|
/test e2e-gcp-upi-xpn |
|
/retest |
|
e2e-gcp-upi is failing due to a hardcoded value here. It is trying to check for the instance group with the old suffix in the name. |
|
This will need be configured first in CI, which must be backwards compatible. For this, I would test if the name in the template is using the new or old scheme, and run different commands based on that. |
|
Corresponding fix for the e2e test is here |
openshift-ci-robot
removed
the
do-not-merge/hold
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Looks like a whole bunch of additional work will need to be done to complement this:
How do we communicate with customers that their existing automation may not work after the change? |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-merge-robot: This pull request references Bugzilla bug 1921627, which is invalid:
Comment Retaining the bugzilla/valid-bug label as it was manually added. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh The requirements for Bugzilla bugs have changed, recalculating validity. |
|
@openshift-merge-robot: This pull request references Bugzilla bug 1921627, which is invalid:
Comment Retaining the bugzilla/valid-bug label as it was manually added. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
/bugzilla refresh |
|
@rna-afk: This pull request references Bugzilla bug 1921627, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (tsze@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/remove-lifecycle rotten |
openshift-ci
bot
removed
the
lifecycle/rotten
|
@rna-afk: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
CI changes have merged. |
|
/test e2e-gcp-upi |
|
The e2e-gcp-upi test was successful. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstuever, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@rna-afk: All pull requests linked via external trackers have merged: Bugzilla bug 1921627 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
GCP has a size restriction of 63 for the instance group name which
is mostly taken up by the suffix -instance-group that is being added
to make sure the resources have unique name. Reducing the size
of the suffix from -instance-group to -ig would help in restricting
the size of the name and would also help in keeping the names
unique.